Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-09 Thread Alan Bateman
On Fri, 9 Dec 2022 01:16:58 GMT, Chris Plummer wrote: >> 3 things to cleanup in this area: >> >> (1) The JDWP agent uses `JNI GetEnv(JVMTI_VERSION_1)` to get a JVMTI >> environment. If `GetEnv` fails the JDWP agent prints this: >> >> `ERROR: JDWP unable to access JVMTI Version 1 (0x3001),

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-09 Thread Alan Bateman
On Fri, 9 Dec 2022 01:16:58 GMT, Chris Plummer wrote: >> 3 things to cleanup in this area: >> >> (1) The JDWP agent uses `JNI GetEnv(JVMTI_VERSION_1)` to get a JVMTI >> environment. If `GetEnv` fails the JDWP agent prints this: >> >> `ERROR: JDWP unable to access JVMTI Version 1 (0x3001),

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v2]

2022-12-09 Thread Afshin Zafari
On Tue, 6 Dec 2022 04:54:50 GMT, David Holmes wrote: > This PR seems to be broken now - full of unexpected changes. The PR changed files are correct now. - PR: https://git.openjdk.org/jdk/pull/11288

Integrated: 8298380: Clean up redundant array length checks in JDK code base

2022-12-09 Thread Sergey Tsypanov
On Thu, 8 Dec 2022 12:37:17 GMT, Sergey Tsypanov wrote: > Newer version of IntelliJ IDEA introduces new > [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) > detecting redundant array length check in snippets like >

Re: RFR: 8298380: Clean up redundant array length checks in JDK code base

2022-12-09 Thread Roger Riggs
On Thu, 8 Dec 2022 12:37:17 GMT, Sergey Tsypanov wrote: > Newer version of IntelliJ IDEA introduces new > [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) > detecting redundant array length check in snippets like >

Re: RFR: 8298380: Clean up redundant array length checks in JDK code base

2022-12-09 Thread Sergey Tsypanov
On Fri, 9 Dec 2022 14:35:47 GMT, Roger Riggs wrote: >> Newer version of IntelliJ IDEA introduces new >> [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) >> detecting redundant array length check in snippets like >>

Re: RFR: 8298380: Clean up redundant array length checks in JDK code base

2022-12-09 Thread Roger Riggs
On Thu, 8 Dec 2022 12:37:17 GMT, Sergey Tsypanov wrote: > Newer version of IntelliJ IDEA introduces new > [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) > detecting redundant array length check in snippets like >

Re: RFR: 8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx [v3]

2022-12-09 Thread Chris Plummer
On Fri, 9 Dec 2022 03:12:36 GMT, Chris Plummer wrote: >> This fixes two separate CRs: >> >> [JDK-8241293](https://bugs.openjdk.org/browse/JDK-8241293) >> CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes >> [JDK-8298073](https://bugs.openjdk.org/browse/JDK-8298073) >> gc/metaspa

Integrated: 8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx

2022-12-09 Thread Chris Plummer
On Thu, 8 Dec 2022 03:06:31 GMT, Chris Plummer wrote: > This fixes two separate CRs: > > [JDK-8241293](https://bugs.openjdk.org/browse/JDK-8241293) > CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes > [JDK-8298073](https://bugs.openjdk.org/browse/JDK-8298073) > gc/metaspace/Com

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-09 Thread Chris Plummer
On Fri, 9 Dec 2022 03:00:36 GMT, Serguei Spitsyn wrote: > Should we consider filing a CSR as potentially there is a minimal > compatibility risk? It don't think it should be necessary. I don't believe there are any known compatibility issues here. Although we switched from requesting `JVMTI_V

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-09 Thread Daniel D . Daugherty
On Fri, 9 Dec 2022 01:16:58 GMT, Chris Plummer wrote: >> 3 things to cleanup in this area: >> >> (1) The JDWP agent uses `JNI GetEnv(JVMTI_VERSION_1)` to get a JVMTI >> environment. If `GetEnv` fails the JDWP agent prints this: >> >> `ERROR: JDWP unable to access JVMTI Version 1 (0x3001),

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-09 Thread Daniel D . Daugherty
On Fri, 9 Dec 2022 01:16:58 GMT, Chris Plummer wrote: >> 3 things to cleanup in this area: >> >> (1) The JDWP agent uses `JNI GetEnv(JVMTI_VERSION_1)` to get a JVMTI >> environment. If `GetEnv` fails the JDWP agent prints this: >> >> `ERROR: JDWP unable to access JVMTI Version 1 (0x3001),

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-09 Thread Chris Plummer
On Fri, 9 Dec 2022 19:39:16 GMT, Daniel D. Daugherty wrote: > if you asked for JVMTI_VERSION_1, could you get back JVMTI_VERSION_1_2 or > JVMTI_VERSION_9 or JVMTI_VERSION_11 if the JVM in question supported each of those versions (and no higher)? Yes, but the debug agent does a version check

RFR: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug

2022-12-09 Thread Chris Plummer
In the log for most SA tests on macos-aarch64-debug, you will see something like: STDOUT: Executable=/System/Volumes/Data/mesos/work_dir/jib-master/install/2022-12-07-2219530.chris.plummer.jdk/macosx-aarch64-debug.jdk/jdk-20/fastdebug/bin/java ... STDOUT: CodeDirectory v=20400 size=758 flags=0x

RFR: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker

2022-12-09 Thread Alex Menkov
The fix updates the test to ignore ThreadDeathEvent event from non-test threads waiting for breakpoint - Commit messages: - Fixed suspendpolicy009 test Changes: https://git.openjdk.org/jdk/pull/11620/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11620&range=00 Issue: h

RFR: 8298514: vmTestbase/nsk/jdi/EventRequestManager/threadDeathRequests/thrdeathreq002/TestDescription.java fails with usage tracker

2022-12-09 Thread Alex Menkov
One more test fix to ignore ThreadDeathEvent event from non-test threads waiting for breakpoint - Commit messages: - Fixed thrdeathreq002 test Changes: https://git.openjdk.org/jdk/pull/11621/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11621&range=00 Issue: https://bug

Re: RFR: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug

2022-12-09 Thread Alex Menkov
On Fri, 9 Dec 2022 22:16:44 GMT, Chris Plummer wrote: > In the log for most SA tests on macos-aarch64-debug, you will see something > like: > > > STDOUT: > Executable=/System/Volumes/Data/mesos/work_dir/jib-master/install/2022-12-07-2219530.chris.plummer.jdk/macosx-aarch64-debug.jdk/jdk-20/fa