RFR: 8298090: Use String.join() instead of manual loop in DescriptorSupport.toString

2022-12-05 Thread Andrey Turbanov
There is opportunity to use String.join in DescriptorSupport.toString implementation. Result code is much shorter and clearer. - Commit messages: - [PATCH] Use String.join() instead of manual loop in DescriptorSupport Changes: https://git.openjdk.org/jdk/pull/10960/files Webrev: h

Re: RFR: 8298090: Use String.join() instead of manual loop in DescriptorSupport.toString

2022-12-05 Thread Sergey Tsypanov
On Wed, 2 Nov 2022 21:30:51 GMT, Andrey Turbanov wrote: > There is opportunity to use String.join in DescriptorSupport.toString > implementation. Result code is much shorter and clearer. Marked as reviewed by stsypanov (Author). - PR: https://git.openjdk.org/jdk/pull/10960

Re: RFR: 8297794: Deprecate JMX Management Applets for Removal [v4]

2022-12-05 Thread Kevin Walls
On Wed, 30 Nov 2022 20:37:38 GMT, Kevin Walls wrote: >> Deprecate the Java Management Extension (JMX) Management Applet (m-let) >> feature for removal. >> >> This deprecation will have no impact on users of other JMX features, the >> JDK's built-in instrumentation, or any of the observability

Integrated: 8297794: Deprecate JMX Management Applets for Removal

2022-12-05 Thread Kevin Walls
On Wed, 30 Nov 2022 12:08:22 GMT, Kevin Walls wrote: > Deprecate the Java Management Extension (JMX) Management Applet (m-let) > feature for removal. > > This deprecation will have no impact on users of other JMX features, the > JDK's built-in instrumentation, or any of the observability tools

Re: RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v39]

2022-12-05 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-434 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.org/jeps/434 Maurizio Cimadamore has updated the pull request incr

Re: RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v39]

2022-12-05 Thread Athijegannathan Sundararajan
On Mon, 5 Dec 2022 10:31:52 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-434 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjdk

Re: Extend Native Memory Tracking over the JDK ? (was: Proposal: track zlib native memory usage with NMT)

2022-12-05 Thread Kennke, Roman
Hi Thomas, I very much like the idea and also your proposals how to do it. Insights in JDK's native memory usage is sorely lacking and would be very useful! I don't have all that much to add about the details beyond what you already covered, though :-) Cheers, Roman Are there any opinions

Re: Extend Native Memory Tracking over the JDK ? (was: Proposal: track zlib native memory usage with NMT)

2022-12-05 Thread Thomas Stüfe
Thank you for the positive encouragement, Roman :-) Cheers, Thomas On Mon, Dec 5, 2022 at 12:03 PM Kennke, Roman wrote: > Hi Thomas, > > I very much like the idea and also your proposals how to do it. Insights > in JDK's native memory usage is sorely lacking and would be very useful! > I don't

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v2]

2022-12-05 Thread Afshin Zafari
> test of tier1-5 passed. Afshin Zafari has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - 8292741:

Re: RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v39]

2022-12-05 Thread Maurizio Cimadamore
On Mon, 5 Dec 2022 10:31:52 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-434 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjdk

Integrated: 8295044: Implementation of Foreign Function and Memory API (Second Preview)

2022-12-05 Thread Maurizio Cimadamore
On Wed, 26 Oct 2022 13:11:50 GMT, Maurizio Cimadamore wrote: > This PR contains the API and implementation changes for JEP-434 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.org

Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v7]

2022-12-05 Thread Bill Huang
> The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to improve this manual process and provide a clearer instr

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v2]

2022-12-05 Thread David Holmes
On Mon, 5 Dec 2022 13:16:44 GMT, Afshin Zafari wrote: >> test of tier1-5 passed. > > Afshin Zafari has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains