> The fix combines almost the same tests to 1 test to remove code duplication
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
Fixed comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11400/files
- new: https:
On Tue, 29 Nov 2022 04:34:22 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Used multiple test tags
>
> test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount/reset001.java
> Can I please get a review for this change which only fixes typos in
> src/hotspot and test/hotspot files? These changes were originally done by
> @mernst in PR https://github.com/openjdk/jdk/pull/10029, but given that the
> other PR touches multiple other files and areas, the progress was stal
On Tue, 29 Nov 2022 04:23:56 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address David's review suggestion
>
> test/hotspot/jtreg/vmTestbase/nsk/share/locks/DeadlockMaker.java line 31:
>
>> 2
On Tue, 29 Nov 2022 08:42:29 GMT, Alex Menkov wrote:
>> The fix combines almost the same tests to 1 test to remove code duplication
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed comments
Marked as reviewed by kevinw
On Mon, 28 Nov 2022 22:12:22 GMT, David Holmes wrote:
>> Alternative for struct?
>
> Not sure ... didn't we start using C++ lambda's for some of these "closure"
> operations? @coleenp what is the usual pattern we use for this kind of thing?
The `unlink` method of `ResourceHashTable` gets an ITE
On Wed, 23 Nov 2022 21:36:24 GMT, Kim Barrett wrote:
>> I think the problem here is the friend declaration, which doesn't look like
>> it's needed and could be deleted.
>
> Digging into this some more, the friend declaration exists to provide access
> to the private `os::win32::enum Ept`.
>
>
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit any final field modification
> CSR: JDK-8281652
Alex
On Tue, 29 Nov 2022 20:18:30 GMT, Alex Menkov wrote:
>> com.sun.jdi.ObjectReference::setValue spec says that final static fields
>> cannot be modified, but openjdk implementation throws
>> IllegalArgumentException for any final fields (static or instance).
>>
>> The fix updates the spec to pro
On Tue, 29 Nov 2022 20:18:30 GMT, Alex Menkov wrote:
>> com.sun.jdi.ObjectReference::setValue spec says that final static fields
>> cannot be modified, but openjdk implementation throws
>> IllegalArgumentException for any final fields (static or instance).
>>
>> The fix updates the spec to pro
On Tue, 22 Nov 2022 19:43:38 GMT, Serguei Spitsyn wrote:
>> Misc stress testing related fixes:
>>
>> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout
>> for another JLI GetObjectSizeIntrinsicsTest.java subtest
>> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Wed, 23 Nov 2022 02:16:30 GMT, David Holmes wrote:
>> @jonathan-gibbons - Thanks for the review!
>>
>> I could not find an @requires incantation for saying
>> do-not-use-slowdebug-bits
>> nor one for saying do-not-use-macosx-aarch64. I don't really do a lot with
>> @requires so I could be mi
On Wed, 23 Nov 2022 17:51:20 GMT, Leonid Mesnik wrote:
>> Misc stress testing related fixes:
>>
>> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout
>> for another JLI GetObjectSizeIntrinsicsTest.java subtest
>> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367)
On Wed, 23 Nov 2022 00:05:54 GMT, Serguei Spitsyn wrote:
>> Does langtools have its own test libraries that I can use to ask the same
>> questions?
>
> Sorry, I was not clear.
> The Fuzz.java has this order:
>
> +import jdk.test.lib.Platform;
> +import jtreg.SkippedException;
>
> I thought, yo
On Tue, 22 Nov 2022 23:17:24 GMT, Jonathan Gibbons wrote:
>> Misc stress testing related fixes:
>>
>> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout
>> for another JLI GetObjectSizeIntrinsicsTest.java subtest
>> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-829736
On Tue, 29 Nov 2022 22:27:46 GMT, Daniel D. Daugherty
wrote:
>> test/jdk/jdk/internal/vm/Continuation/Fuzz.java line 90:
>>
>>> 88:
>>> 89: public static void main(String[] args) {
>>> 90: if (Platform.isSlowDebugBuild() && Platform.isOSX() &&
>>> Platform.isAArch64()) {
>>
>> I
On Wed, 23 Nov 2022 02:28:02 GMT, Chris Plummer wrote:
> Do you plan on closing the CRs associated with these changes even though the
> root causes are not being addressed, just avoided?
These two CRs are like ProblemListing bugs:
[JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367): dis
On Mon, 28 Nov 2022 22:16:34 GMT, David Holmes wrote:
>> Coleen's suggestion for efficiency reasons.
>
> If the comment is meant to suggest some possible future optimisation it
> should say that.
Oh you should uncomment that code. The hashtable that this replaces has the
same early cut-out for
On Tue, 29 Nov 2022 12:22:38 GMT, Afshin Zafari wrote:
>> Not sure ... didn't we start using C++ lambda's for some of these "closure"
>> operations? @coleenp what is the usual pattern we use for this kind of thing?
>
> The `unlink` method of `ResourceHashTable` gets an ITER type and calls its
>
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty
wrote:
> Misc stress testing related fixes:
>
> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for
> another JLI GetObjectSizeIntrinsicsTest.java subtest
> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Mon, 28 Nov 2022 19:29:08 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty
wrote:
> Misc stress testing related fixes:
>
> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for
> another JLI GetObjectSizeIntrinsicsTest.java subtest
> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Tue, 29 Nov 2022 17:07:02 GMT, Julian Waters wrote:
>> Digging into this some more, the friend declaration exists to provide access
>> to the private `os::win32::enum Ept`.
>>
>> One obvious and cheap solution to that would be to make that enum public. I
>> think that would be an improveme
On Tue, 29 Nov 2022 09:15:20 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which only fixes typos in
>> src/hotspot and test/hotspot files? These changes were originally done by
>> @mernst in PR https://github.com/openjdk/jdk/pull/10029, but given that the
>> other PR t
On Wed, 23 Nov 2022 04:58:38 GMT, Kim Barrett wrote:
>> Out of curiosity, is there a way to get the discussion on approving the use
>> of alignas back up? I've read through 8250269 briefly and unlike the issues
>> that come with C++ attributes, alignas looks relatively straightforward to
>> sw
26 matches
Mail list logo
