Re: RFR: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files

2022-10-14 Thread Claes Redestad
On Fri, 14 Oct 2022 06:20:28 GMT, Ioi Lam wrote: > This PR reverts JDK-8276687, which has caused tier1 test failures. Marked as reviewed by redestad (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10711

Re: RFR: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files

2022-10-14 Thread Kevin Walls
On Fri, 14 Oct 2022 06:20:28 GMT, Ioi Lam wrote: > This PR reverts JDK-8276687, which has caused tier1 test failures. Marked as reviewed by kevinw (Committer). Hi, are you sure you want to back this out? I'll click approve as backout change I think looks OK. I see test/hotspot/jtreg/serviceabi

Re: RFR: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files

2022-10-14 Thread Daniel D . Daugherty
On Fri, 14 Oct 2022 06:20:28 GMT, Ioi Lam wrote: > This PR reverts JDK-8276687, which has caused tier1 test failures. @iklam - Are you planning to integrate this [BACKOUT] soon? The CI looks like a train wreck in Tier1 and Tier3 so far... - PR: https://git.openjdk.org/jdk/pull/1071

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Fei Yang
On Fri, 14 Oct 2022 01:19:27 GMT, Fei Yang wrote: > > Here is the basic support for RISC-V: > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > -- I adapted this from AArch64 changes, and tested it very lightly. > > @RealFYang, can I leave the testing and follow up fixes to y

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Roman Kennke
On Fri, 14 Oct 2022 13:45:07 GMT, Fei Yang wrote: > > > Here is the basic support for RISC-V: > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > -- I adapted this from AArch64 changes, and tested it very lightly. > > > @RealFYang, can I leave the testing and follow up fi

Integrated: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files

2022-10-14 Thread Ioi Lam
On Fri, 14 Oct 2022 06:20:28 GMT, Ioi Lam wrote: > This PR reverts JDK-8276687, which has caused tier1 test failures. This pull request has now been integrated. Changeset: dfcd9d53 Author:Ioi Lam URL: https://git.openjdk.org/jdk/commit/dfcd9d538eba4b097083abe19d02d6d019236ac7 Stats:

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Fei Yang
On Fri, 14 Oct 2022 14:26:20 GMT, Roman Kennke wrote: > > > > Here is the basic support for RISC-V: > > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > > -- I adapted this from AArch64 changes, and tested it very lightly. > > > > @RealFYang, can I leave the testing and

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Roman Kennke
On Fri, 14 Oct 2022 14:32:57 GMT, Fei Yang wrote: > > > > > Here is the basic support for RISC-V: > > > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > > > -- I adapted this from AArch64 changes, and tested it very lightly. > > > > > @RealFYang, can I leave the testing

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Fei Yang
On Fri, 14 Oct 2022 14:39:01 GMT, Roman Kennke wrote: > > > > > > Here is the basic support for RISC-V: > > > > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > > > > -- I adapted this from AArch64 changes, and tested it very lightly. > > > > > > @RealFYang, can I leave

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Roman Kennke
On Fri, 14 Oct 2022 14:53:57 GMT, Fei Yang wrote: > > > > > > > Here is the basic support for RISC-V: > > > > > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > > > > > -- I adapted this from AArch64 changes, and tested it very > > > > > > > lightly. @RealFYang, can I le

Re: RFR: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files

2022-10-14 Thread Ioi Lam
On Fri, 14 Oct 2022 09:53:23 GMT, Kevin Walls wrote: > Hi, are you sure you want to back this out? I'll click approve as backout > change I think looks OK. > > I see test/hotspot/jtreg/serviceability/dcmd/framework/VMVersionTest.java > failing SOMETIMES for me. I think you already noted that

Re: RFR: 8294993: LingeredApp test update

2022-10-14 Thread Chris Plummer
On Fri, 7 Oct 2022 19:54:54 GMT, Kevin Walls wrote: > There are a few changes we can make to better understand the LingeredApp test > when it goes wrong: > > startAppExactJvmOpts() should not try and call finishApp unless the process > isAlive, that just creates a misleading exception. > > wa

Re: RFR: 8294993: LingeredApp test update

2022-10-14 Thread Chris Plummer
On Fri, 7 Oct 2022 19:54:54 GMT, Kevin Walls wrote: > There are a few changes we can make to better understand the LingeredApp test > when it goes wrong: > > startAppExactJvmOpts() should not try and call finishApp unless the process > isAlive, that just creates a misleading exception. > > wa