> See the description in the bug. This fixes only Linux x86_32, because only
> there I could reproduce the failure. Windows x86_32 seems to be fine. I have
> no access to BSD x86_32.
>
> Additional testing:
> - [x] Linux x86 fastdebug `serviceability/sa` now cleanly passes
Aleksey Shipilev has
On Tue, 4 Oct 2022 17:59:36 GMT, Alan Bateman wrote:
> This is a test only change for two tests for virtual threads that
> hang/timeout on single core systems. The two tests involve pinning and
> require at least two carrier threads. The test lib used by these tests is
> updated to define a ne
On Thu, 6 Oct 2022 02:24:12 GMT, Alex Menkov wrote:
> Test failure is a duplicate of
> [JDK-8284777](https://bugs.openjdk.org/browse/JDK-8284777), but the test
> needs to be updated:
> - the test instruments all loaded classes, so need to updated ASM version to
> support records and permits;
>
On Fri, 7 Oct 2022 07:05:44 GMT, Aleksey Shipilev wrote:
>> See the description in the bug. This fixes only Linux x86_32, because only
>> there I could reproduce the failure. Windows x86_32 seems to be fine. I have
>> no access to BSD x86_32.
>>
>> Additional testing:
>> - [x] Linux x86 fastd
On Thu, 6 Oct 2022 17:31:00 GMT, Serguei Spitsyn wrote:
>> The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require
>> the target thread to be suspended. If not suspended then the
>> JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the
>> implementation.
>>
>> The
Hi Dmitry,
Do you have any plans to full review and approve this PR?
Thanks,
Serguei
From: hotspot-dev on behalf of Dmitry Samersoff
Date: Friday, October 7, 2022 at 1:34 AM
To: Serguei Spitsyn , hotspot-...@openjdk.org
, serviceability-dev@openjdk.org
Subject: Re: RFR: 8288387: GetLocalXXX
On Fri, 7 Oct 2022 09:02:11 GMT, Serguei Spitsyn wrote:
> PING: Could someone review the CSR, please?
I reviewed it yesterday.
-
PR: https://git.openjdk.org/jdk/pull/10586
On Thu, 6 Oct 2022 17:31:00 GMT, Serguei Spitsyn wrote:
>> The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require
>> the target thread to be suspended. If not suspended then the
>> JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the
>> implementation.
>>
>> The
On Fri, 23 Sep 2022 17:08:46 GMT, Johan Sjölen wrote:
> Here's a suggested solution for the ticket mentioned and a use case for
> outputStream. I'm not attached to the name.
>
> This saves space for all allocated outputStreams, which is nice. It also
> makes the purpose of ResourceObj more cle
On Thu, 6 Oct 2022 17:31:00 GMT, Serguei Spitsyn wrote:
>> The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require
>> the target thread to be suspended. If not suspended then the
>> JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the
>> implementation.
>>
>> The
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
Hi Serguei,
Looks good for me. Thank you!
-Dmitry
On 06/10/2022 20:31, Serguei Spitsyn wrote:
On Thu, 6 Oct 2022 07:16:44 GMT, Dmitry Samersoff
wrote:
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revision:
addressed review commen
On Mon, 12 Sep 2022 20:10:45 GMT, Alex Menkov wrote:
>> I like the fact that the fix is small and I really like the new test. I only
>> have minor comments and a couple of questions.
>>
>> Please run these changes thru Tier[456] since that's where JVM/TI
>> tests run in different configs w/ diff
On Thu, 6 Oct 2022 17:44:22 GMT, Alex Menkov wrote:
>> The problem is RedefineClasses does not update cached_class_bytes, so
>> subsequent RetransformClasses gets obsolete class bytes (this are testcases
>> 3-6 from the new test)
>>
>> cached_class_bytes are set when an agent instruments the c
On Mon, 12 Sep 2022 20:23:09 GMT, Alex Menkov wrote:
>> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRetransform/RedefineRetransform.java
>> line 240:
>>
>>> 238: case 5:
>>> 239: test("Redefine-Retransform-Redefine-Retransform with
>>> CFLH", () -> {
>>>
On Thu, 6 Oct 2022 02:24:12 GMT, Alex Menkov wrote:
> Test failure is a duplicate of
> [JDK-8284777](https://bugs.openjdk.org/browse/JDK-8284777), but the test
> needs to be updated:
> - the test instruments all loaded classes, so need to updated ASM version to
> support records and permits;
>
On Thu, 6 Oct 2022 17:31:00 GMT, Serguei Spitsyn wrote:
>> The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require
>> the target thread to be suspended. If not suspended then the
>> JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the
>> implementation.
>>
>> The
On Fri, 7 Oct 2022 07:05:44 GMT, Aleksey Shipilev wrote:
>> See the description in the bug. This fixes only Linux x86_32, because only
>> there I could reproduce the failure. Windows x86_32 seems to be fine. I have
>> no access to BSD x86_32.
>>
>> Additional testing:
>> - [x] Linux x86 fastd
On Fri, 7 Oct 2022 07:05:44 GMT, Aleksey Shipilev wrote:
>> See the description in the bug. This fixes only Linux x86_32, because only
>> there I could reproduce the failure. Windows x86_32 seems to be fine. I have
>> no access to BSD x86_32.
>>
>> Additional testing:
>> - [x] Linux x86 fastd
On Thu, 6 Oct 2022 18:59:57 GMT, Aleksey Shipilev wrote:
> See the description in the bug. This fixes only Linux x86_32, because only
> there I could reproduce the failure. Windows x86_32 seems to be fine. I have
> no access to BSD x86_32.
>
> Additional testing:
> - [x] Linux x86 fastdebug `
On Sat, 1 Oct 2022 01:12:52 GMT, Chris Plummer wrote:
> The bug is due to the debug agent still having a reference to one of the
> classes when the full GC is issued by the debuggee, thus keeping the classes
> loaded. The debug agent it about to free the reference, but doesn't do it
> quite so
> The problem is RedefineClasses does not update cached_class_bytes, so
> subsequent RetransformClasses gets obsolete class bytes (this are testcases
> 3-6 from the new test)
>
> cached_class_bytes are set when an agent instruments the class from
> ClassFileLoadHook.
> After successful Redefine
On Fri, 7 Oct 2022 15:15:25 GMT, Daniel D. Daugherty wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed compilation error on linux
>
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRetransform/l
23 matches
Mail list logo
