Integrated: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts

2022-09-30 Thread Severin Gehwolf
On Tue, 13 Sep 2022 13:06:10 GMT, Severin Gehwolf wrote: > Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more comm

RFR: 8283093: JMX connections should default to using an ObjectInputFilter

2022-09-30 Thread Kevin Walls
Set the management.properties "com.sun.management.jmxremote.serial.filter.pattern" value by default, to restrict types that can be deserialized. Use the example value from the Core Libraries guide (see section 2. Serialization Filtering / Built-in Filters / Filters for JMX), plus Subject whic

Re: RFR: 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: JVMTI_ERROR_WRONG_PHASE

2022-09-30 Thread Robbin Ehn
On Fri, 30 Sep 2022 01:32:44 GMT, Leonid Mesnik wrote: > 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: > JVMTI_ERROR_WRONG_PHASE The reason for it to be a daemon is that this thread should try to suspend/resume when we are terminating, thus trying to hit those rare exit par

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-30 Thread Magnus Ihse Bursie
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated th

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-30 Thread Weijun Wang
On Fri, 30 Sep 2022 04:05:51 GMT, Iris Clark wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> http -> https > > src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line > 34: > >> 32: * the follo

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter

2022-09-30 Thread Daniel Fuchs
On Fri, 30 Sep 2022 11:00:28 GMT, Kevin Walls wrote: > Set the management.properties > "com.sun.management.jmxremote.serial.filter.pattern" value by default, to > restrict types that can be deserialized. > > Use the example value from the Core Libraries guide (see section 2. > Serialization

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter

2022-09-30 Thread Kevin Walls
On Fri, 30 Sep 2022 15:11:26 GMT, Daniel Fuchs wrote: > Hi Kevin - have you tried connecting with jconsole to a java program (you can > e.g. connect jconsole to itself) and verified that all looked OK and that > there wasn't any exception logged while clicking through the various MBeans > it e

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-30 Thread Phil Race
On Fri, 30 Sep 2022 14:16:24 GMT, Weijun Wang wrote: >> src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line >> 34: >> >>> 32: * the following link: >>> 33: * >>> 34: * >>> http://hg.openjdk.org/jdk9/jdk9/jdk/raw-file/tip/src/jdk.accessibility/windows/native/bridge/A

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-30 Thread Joe Wang
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated th

Re: RFR: 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: JVMTI_ERROR_WRONG_PHASE

2022-09-30 Thread Serguei Spitsyn
On Fri, 30 Sep 2022 01:32:44 GMT, Leonid Mesnik wrote: > 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: > JVMTI_ERROR_WRONG_PHASE The fix looks good. Thanks, Serguei Thanks, Robbin. I see the point. - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.o

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v5]

2022-09-30 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request with a new target base due to a merge or a re

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-30 Thread Joe Darcy
On Fri, 30 Sep 2022 13:59:12 GMT, Magnus Ihse Bursie wrote: > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it > might warrant a separate PR..? Yes; I think it is sufficient to update src and doc with this PR. - PR: https://git.openjdk.org/jdk/pull/10501

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-30 Thread Joe Darcy
On Fri, 30 Sep 2022 17:38:54 GMT, Phil Race wrote: > This is correct. AccessBridge.h is published with the include/header files of > the JDK and anyone reading it there can't exactly make use of "../" Update to persistent git links. - PR: https://git.openjdk.org/jdk/pull/10501

RFR: 8294689: The SA transported_core.html file needs quite a bit of work

2022-09-30 Thread Chris Plummer
The main issues I set out to address are: - legacy Solaris references can be removed - add help with dealing with Windows core files, most of important of which is use of PATH to find the dlls referenced by the core file. - add help with dealing with macOS core files, most of important of which i

RFR: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading

2022-09-30 Thread Chris Plummer
The bug is due to the debug agent still having a reference to one of the classes when the full GC is issued by the debuggee, thus keeping the classes loaded. The debug agent it about to free the reference, but doesn't do it quite soon enough, and then it is blocked from freeing it by the full GC