Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-03 Thread Dean Long
On Fri, 2 Sep 2022 00:04:17 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with variable-sized >> streams). >> >>

Re: RFR: 8291586: Broken links in JVMTI specification

2022-09-03 Thread Serguei Spitsyn
On Sat, 3 Sep 2022 00:52:56 GMT, Serguei Spitsyn wrote: > The Loom related spec of the extension VirtualThreadMount and > VirtualThreadUnmount events in the jvmti.xml is surrounded by the elements > ` ... `, so these specs have to be ignored when the > `jvmti.html `is generated. However the `j

Re: RFR: 7124710: interleaved RedefineClasses() and RetransformClasses() calls may have a problem [v2]

2022-09-03 Thread Serguei Spitsyn
On Wed, 31 Aug 2022 21:28:24 GMT, Alex Menkov wrote: >> The problem is RedefineClasses does not update cached_class_bytes, so >> subsequent RetransformClasses gets obsolete class bytes (this are testcases >> 3-6 from the new test) >> >> cached_class_bytes are set when an agent instruments the

Re: RFR: 7124710: interleaved RedefineClasses() and RetransformClasses() calls may have a problem [v2]

2022-09-03 Thread Serguei Spitsyn
On Wed, 31 Aug 2022 21:28:24 GMT, Alex Menkov wrote: >> The problem is RedefineClasses does not update cached_class_bytes, so >> subsequent RetransformClasses gets obsolete class bytes (this are testcases >> 3-6 from the new test) >> >> cached_class_bytes are set when an agent instruments the

Re: RFR: 7124710: interleaved RedefineClasses() and RetransformClasses() calls may have a problem [v2]

2022-09-03 Thread Serguei Spitsyn
On Wed, 31 Aug 2022 21:28:24 GMT, Alex Menkov wrote: >> The problem is RedefineClasses does not update cached_class_bytes, so >> subsequent RetransformClasses gets obsolete class bytes (this are testcases >> 3-6 from the new test) >> >> cached_class_bytes are set when an agent instruments the

Re: RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread

2022-09-03 Thread Kevin Walls
On Fri, 2 Sep 2022 20:33:37 GMT, David Holmes wrote: >> This is an MR which partially reverts JDK-8289091 such that >> JavaThread::threadObj() does not call Thread::current(). >> >> A JVMTI operation could call threadObj() and clear the Windows GetLastError >> value. >> >> Partial, because I

Re: RFR: 8292201: serviceability/sa/ClhsdbThreadContext.java fails with "'Thread "Common-Cleaner"' missing from stdout/stderr" [v3]

2022-09-03 Thread Chris Plummer
On Fri, 2 Sep 2022 03:20:56 GMT, Chris Plummer wrote: >> While dumping all registers (and doing a findpc on each), the following >> exception occurred for r8: >> >> >> r8: 0x00750e4fdffc >> Error: java.lang.ArrayIndexOutOfBoundsException: Index 4099 out of bounds >> for length 4096 >> ja

Integrated: 8292201: serviceability/sa/ClhsdbThreadContext.java fails with "'Thread "Common-Cleaner"' missing from stdout/stderr"

2022-09-03 Thread Chris Plummer
On Tue, 30 Aug 2022 23:57:55 GMT, Chris Plummer wrote: > While dumping all registers (and doing a findpc on each), the following > exception occurred for r8: > > > r8: 0x00750e4fdffc > Error: java.lang.ArrayIndexOutOfBoundsException: Index 4099 out of bounds for > length 4096 > java.lang

Integrated: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling

2022-09-03 Thread Chris Plummer
On Fri, 2 Sep 2022 18:49:27 GMT, Chris Plummer wrote: > While trying to find a fix for > [JDK-8288429](https://bugs.openjdk.org/browse/JDK-8288429) (no fix was > found), I made some adjustments to the error handling in > catch_mach_exception_raise() to make it a bit easier to understand the co

Re: RFR: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling

2022-09-03 Thread Chris Plummer
On Fri, 2 Sep 2022 18:49:27 GMT, Chris Plummer wrote: > While trying to find a fix for > [JDK-8288429](https://bugs.openjdk.org/browse/JDK-8288429) (no fix was > found), I made some adjustments to the error handling in > catch_mach_exception_raise() to make it a bit easier to understand the co

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v3]

2022-09-03 Thread John R Rose
> Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gtests. John R Rose has updated the pull request increme

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-03 Thread Chris Plummer
On Sat, 3 Sep 2022 07:48:50 GMT, Dean Long wrote: > Wouldn't the SA stack walk fail when attaching to a core dump from an earlier > JVM that does not exclude nulls? I'm not sure how important compatibility is with older JVMs. SA is capable of (if properly maintained) connecting to any JVM. You