Re: RFR: JDK-8292595: jdwp utf_util getWideString might leak memory

2022-08-23 Thread Matthias Baesken
On Thu, 18 Aug 2022 11:51:52 GMT, Matthias Baesken wrote: > There seems to be a case where utf_util.c getWideString might leak memory in > an early return. In case of failing getWideString, we have already a fallback in place that is just copying bytes : wstr = getWideString(CP_UTF8, (cha

RFR: JDK-8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free

2022-08-23 Thread Matthias Baesken
There seems to be a case where EncodingSupport_md.c convertUtf8ToPlatformString might leak memory because of a wrong placing of free.. - Commit messages: - JDK-8292778 Changes: https://git.openjdk.org/jdk/pull/9981/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9981&range=

Re: RFR: JDK-8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free

2022-08-23 Thread Roger Riggs
On Tue, 23 Aug 2022 13:59:53 GMT, Matthias Baesken wrote: > There seems to be a case where EncodingSupport_md.c > convertUtf8ToPlatformString might leak memory because of a wrong placing of > free.. LGTM - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.org/jdk/

Re: RFR: JDK-8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free

2022-08-23 Thread Kevin Walls
On Tue, 23 Aug 2022 13:59:53 GMT, Matthias Baesken wrote: > There seems to be a case where EncodingSupport_md.c > convertUtf8ToPlatformString might leak memory because of a wrong placing of > free.. Marked as reviewed by kevinw (Committer). - PR: https://git.openjdk.org/jdk/pull/

Re: RFR: JDK-8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free

2022-08-23 Thread Alex Menkov
On Tue, 23 Aug 2022 13:59:53 GMT, Matthias Baesken wrote: > There seems to be a case where EncodingSupport_md.c > convertUtf8ToPlatformString might leak memory because of a wrong placing of > free.. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.org/jdk/pull/

Re: RFR: 8292250: Create test for co-located JDI MethodEntry, Step, and Breakpoint events [v3]

2022-08-23 Thread Chris Plummer
> We currently have no tests for co-located MethodEntry, Step, and Breakpoint > events. We should make sure they are being properly co-located as described > in the JDI spec, and also do special test cases for > [JDK-8292217](https://bugs.openjdk.org/browse/JDK-8292217). > > https://docs.oracle

Re: RFR: 8292250: Create test for co-located JDI MethodEntry, Step, and Breakpoint events [v2]

2022-08-23 Thread Chris Plummer
On Fri, 19 Aug 2022 22:41:00 GMT, Alex Menkov wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix minor typo in output. > > test/jdk/com/sun/jdi/CLETest.java line 137: > >> 135: String method; >> 136: