Re: RFR: 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a percentage\: 68.31\: expected true, was false" [v2]

2022-08-09 Thread Kevin Walls
On Tue, 9 Aug 2022 02:35:14 GMT, Leonid Mesnik wrote: >> The test should use the same locales in all processes, the default language >> should work fine. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > fix Thanks, great

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v4]

2022-08-09 Thread Alexey Semenyuk
On Fri, 29 Jul 2022 18:13:25 GMT, Alisen Chung wrote: >> open l10n msg drop >> All tests passed. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added comments in CurrencyNames root in base, moved US CurrencyNames back > t

Re: RFR: 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a percentage\: 68.31\: expected true, was false" [v3]

2022-08-09 Thread Leonid Mesnik
> The test should use the same locales in all processes, the default language > should work fine. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed print - Changes: - all: https://git.openjdk.org/jdk/pull/9798/fi

Re: RFR: 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a percentage\: 68.31\: expected true, was false" [v2]

2022-08-09 Thread Leonid Mesnik
On Tue, 9 Aug 2022 14:20:13 GMT, Kevin Walls wrote: > Thanks, great to fix the verifier now if we can. > > I do think that never setting user.language is good. Forcing jstat to run > with user.language=en could be wrong, as there is a risk of mismatching the > printing and the verification. >

RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version

2022-08-09 Thread Bill Huang
This task converts 5 shell tests below to java version. test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh test/java/lang/management/MemoryMXBean/MemoryT

Re: RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version

2022-08-09 Thread Leonid Mesnik
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote: > This task converts 5 shell tests below to java version. > test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh > test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh > test/java/lang/management/MemoryMXBean/MemoryManageme

[jdk19] Integrated: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

2022-08-09 Thread Alisen Chung
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote: > open l10n msg drop > All tests passed. This pull request has now been integrated. Changeset: 0def5316 Author:Alisen Chung Committer: Alexey Semenyuk URL: https://git.openjdk.org/jdk19/commit/0def5316cd2ec7699c649bf67bf58e6315c

Re: RFR: 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a percentage\: 68.31\: expected true, was false" [v3]

2022-08-09 Thread Kevin Walls
On Tue, 9 Aug 2022 20:29:42 GMT, Leonid Mesnik wrote: >> The test should use the same locales in all processes, the default language >> should work fine. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > fixed print Marked

Re: RFR: 8289711: Add container configuration data to mbeans [v10]

2022-08-09 Thread xpbob
> Container configuration information is useful for troubleshooting > problems,Exposing information in MBeans is ideal for monitoring, jConsole, > and other scenarios. > Results the following > ![图片](https://user-images.githubusercontent.com/7837910/177248834-50beefe9-4db6-470c-8f15-df5a93892804.

Re: [External] : Re: Grouped method entry events

2022-08-09 Thread Chris Plummer
Hi Egor, While trying to write a JDI test to reproduce this issue (and having trouble getting it to fail), I learned a bit more about why your test case is failing. It's not the call to System.out.println() that is triggering the problem, it is the constant pool resolution for java.lang.Syste

Re: [External] : Re: Grouped method entry events

2022-08-09 Thread Chris Plummer
Hi Egor, Although the patch below does seem to fix  your specific issue, and I haven't seen it cause any new test failures, I don't think it's really the right fix. Rather than fixing the underlying issue, I'd say it just avoids it in your specific case, but likely the issue is still there wh