Re: RFR: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName

2022-07-25 Thread Aleksey Shipilev
On Sat, 23 Jul 2022 19:41:07 GMT, Leonid Mesnik wrote: > Fixed tests that use eName to print event name to print the class name. Plus > some minor refactoring. Looks reasonable. - Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.org/jdk/pull/9624

Re: RFR: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName

2022-07-25 Thread Serguei Spitsyn
On Sat, 23 Jul 2022 19:41:07 GMT, Leonid Mesnik wrote: > Fixed tests that use eName to print event name to print the class name. Plus > some minor refactoring. I've added a couple of nits. Otherwise, it looks good. Thanks, Serguei test/hotspot/jtreg/vmTestbase/nsk/jdi/Event/request/request001.

RFR: 8290074: Remove implicit arguments for RegisterMap constructor

2022-07-25 Thread Axel Boldt-Christmas
8290074: Remove implicit arguments for RegisterMap constructor - Commit messages: - Fix spurious semicolon - Change to scoped enum - 8290074: Remove implicit arguments for RegisterMap constructor - 8290074: Remove implicit arguments for RegisterMap constructor - 8290074: Remove i

Re: RFR: 8290074: Remove implicit arguments for RegisterMap constructor

2022-07-25 Thread Erik Österlund
On Mon, 11 Jul 2022 14:58:07 GMT, Axel Boldt-Christmas wrote: > 8290074: Remove implicit arguments for RegisterMap constructor Looks good except for a spurious semicolon. Don't need another review for that. src/hotspot/share/runtime/frame.cpp line 85: > 83: RegisterMap::RegisterMap(oop continu

Re: RFR: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName

2022-07-25 Thread Chris Plummer
On Sat, 23 Jul 2022 19:41:07 GMT, Leonid Mesnik wrote: > Fixed tests that use eName to print event name to print the class name. Plus > some minor refactoring. Changes requested by cjplummer (Reviewer). test/hotspot/jtreg/vmTestbase/nsk/jdi/Event/request/request001.java line 560: > 558:

Re: RFR: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName

2022-07-25 Thread Chris Plummer
On Mon, 25 Jul 2022 09:27:28 GMT, Serguei Spitsyn wrote: >> Fixed tests that use eName to print event name to print the class name. Plus >> some minor refactoring. > > test/hotspot/jtreg/vmTestbase/nsk/jdi/Event/request/request001.java line 553: > >> 551: log3("ERROR: else c

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

2022-07-25 Thread Naoto Sato
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote: > open l10n msg drop > All tests passed. Changes requested by naoto (Reviewer). src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties line 63: > 61: # written authorization of the copyright holder. > 62: > 63: ADP=ADP

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

2022-07-25 Thread Alexey Semenyuk
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote: > open l10n msg drop > All tests passed. Why `MSG_Help_mac_launcher` in [src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_de.properties](https://github.com/openjdk/jdk19/pull/154/files#diff-2e1b121e201e1040827d5b6

Re: RFR: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName [v2]

2022-07-25 Thread Leonid Mesnik
> Fixed tests that use eName to print event name to print the class name. Plus > some minor refactoring. Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull r

Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform [v2]

2022-07-25 Thread KIRIYAMA Takuya
> Failed tests call java.lang.ProcessBuilder in direct, so not used command > options specified when jtreg command run. > To run non-localized tests, the locale options should be added in > ProcessBuilder. > > Could you review this fix, please? KIRIYAMA Takuya has updated the pull request incr

Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform

2022-07-25 Thread KIRIYAMA Takuya
On Wed, 20 Jul 2022 20:47:31 GMT, Chris Plummer wrote: >> Failed tests call java.lang.ProcessBuilder in direct, so not used command >> options specified when jtreg command run. >> To run non-localized tests, the locale options should be added in >> ProcessBuilder. >> >> Could you review this

Re: RFR: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName [v2]

2022-07-25 Thread Serguei Spitsyn
On Tue, 26 Jul 2022 04:55:21 GMT, Leonid Mesnik wrote: >> Fixed tests that use eName to print event name to print the class name. Plus >> some minor refactoring. > > Leonid Mesnik has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes t