Re: Seemingly erroneous return value in HotSpot test

2023-09-14 Thread David Holmes
On 15/09/2023 12:02 pm, Julian Waters wrote: Just a heads up, there are even more instances of a method supposed to return a jboolean returning JNI_ERR instead in other places as well, which seems to be fairly concerning: It is only error paths that should never really happen. But yes a bug.

Re: Seemingly erroneous return value in HotSpot test

2023-09-14 Thread Julian Waters
Just a heads up, there are even more instances of a method supposed to return a jboolean returning JNI_ERR instead in other places as well, which seems to be fairly concerning: === Output from failing command(s) repeated here === * For target support_test_hotspot_jtreg_native_support_libhs103t002_

Re: Seemingly erroneous return value in HotSpot test

2023-09-14 Thread Chris Plummer
I think it should return false like is does with verify_tag(). This will cause the test to fail, which it what we would want in this case Chris On 9/13/23 11:20 PM, David Holmes wrote: Hi Julian, This is a serviceability issue - cc'd. On 14/09/2023 12:48 pm, Julian Waters wrote: Hi all, In

Re: Seemingly erroneous return value in HotSpot test

2023-09-13 Thread David Holmes
Hi Julian, This is a serviceability issue - cc'd. On 14/09/2023 12:48 pm, Julian Waters wrote: Hi all, In the HotSpot test /test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateThroughHeap/filter-tagged/HeapFilter.cpp, the method occurance_expected, which returns a jboolean, returns JNI_ERR in an e