On Wed, 10 Jan 2024 22:34:57 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
On Wed, 10 Jan 2024 22:34:57 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
On Wed, 10 Jan 2024 23:12:40 GMT, Alex Menkov wrote:
>> Ok. I see now how the old code was actually reversing the order to undo the
>> reversing that was already done.
>
>> I think the indent here should be 4, not 6.
>
> I updated indentation to be consistent with other multi-line statements in
On Wed, 10 Jan 2024 22:34:57 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
On Wed, 10 Jan 2024 17:28:33 GMT, Chris Plummer wrote:
>> FieldStream from reflectionUtils iterates fields in reverse order, so
>> reversing again was previously needed here. JavaFieldStream from
>> fieldStreams (and the new FilteredJavaFieldStream) iterate in the order the
>> fields actually
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.openjdk.org/browse/JDK-8317692) for details).
> The cha
On Wed, 10 Jan 2024 10:16:01 GMT, Hannes Greule wrote:
>> You said in the description that the order was reversed, but I don't see
>> where that is getting fixed. It seems it was partially fixed by
>> [JDK-8317692](https://bugs.openjdk.org/browse/JDK-8317692), but it is only
>> preserving the
On Wed, 10 Jan 2024 05:28:39 GMT, Chris Plummer wrote:
>> src/hotspot/share/prims/jvmtiEnv.cpp line 2910:
>>
>>> 2908: result_list[i] = jfieldIDWorkaround::to_jfieldID(
>>> 2909: ik, flds.offset(),
>>> 2910: flds.access_flags().is_static());
>>
>> I think the indent here
On Wed, 10 Jan 2024 05:20:27 GMT, Chris Plummer wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright headers
>
> src/hotspot/share/prims/jvmtiEnv.cpp line 2910:
>
>> 2908: result_list[i] = jfieldIDWorkarou
On Wed, 10 Jan 2024 02:39:33 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
On Wed, 10 Jan 2024 02:39:33 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.openjdk.org/browse/JDK-8317692) for details).
> The cha
On Wed, 13 Dec 2023 21:32:50 GMT, Alex Menkov wrote:
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.
On Wed, 13 Dec 2023 21:32:50 GMT, Alex Menkov wrote:
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.
On Wed, 13 Dec 2023 21:32:50 GMT, Alex Menkov wrote:
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.
15 matches
Mail list logo
