On Mon, 8 May 2023 10:09:29 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wrong
On Mon, 8 May 2023 10:09:29 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wrong
On Mon, 8 May 2023 11:01:56 GMT, Johan Sjölen wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Dead assert
>
> Passes tier1.
Thanks @jdksjolen , I am rubberstamping this.
-
PR Comment: https://git.ope
On Mon, 8 May 2023 10:09:29 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wrong
On Mon, 8 May 2023 10:09:29 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wrong
On Mon, 8 May 2023 10:00:45 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wrong
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/jfr/. Unfortunately the script that does the change isn't perfect, and
> so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my ey
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/jfr/. Unfortunately the script that does the change isn't perfect, and
> so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my ey
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/jfr/. Unfortunately the script that does the change isn't perfect, and
> so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my ey
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/jfr/. Unfortunately the script that does the change isn't perfect, and
> so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my ey
On Tue, 24 Jan 2023 21:10:31 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wron
On Tue, 24 Jan 2023 21:10:31 GMT, Johan Sjölen wrote:
>> Do the conversion in the share/jfr/ sub-directory and all of its files.
>
> Johan Sjölen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix outdated copyright
Status: Clang fails bu
On Tue, 24 Jan 2023 20:58:27 GMT, Johan Sjölen wrote:
>> Do the conversion in the share/jfr/ sub-directory and all of its files.
>
> Johan Sjölen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Manual fix
Found one file which now has no ch
> Do the conversion in the share/jfr/ sub-directory and all of its files.
Johan Sjölen has updated the pull request incrementally with one additional
commit since the last revision:
Fix outdated copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12034/files
- new: h
> Do the conversion in the share/jfr/ sub-directory and all of its files.
Johan Sjölen has updated the pull request incrementally with one additional
commit since the last revision:
Manual fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12034/files
- new: https://git.o
> Do the conversion in the share/jfr/ sub-directory and all of its files.
Johan Sjölen has updated the pull request incrementally with one additional
commit since the last revision:
Fix two faulty NULL_STRING misses
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12034/files
On Tue, 17 Jan 2023 11:26:12 GMT, Johan Sjölen wrote:
> Do the conversion in the share/jfr/ sub-directory and all of its files.
Hi @mgronlun, the "fix" comments are there because I intend to revert the
macros to regular old `NULL`. I'll copy paste a more informative comment next
time :).
Also
On Thu, 19 Jan 2023 20:44:33 GMT, Johan Sjölen wrote:
>> Do the conversion in the share/jfr/ sub-directory and all of its files.
>
> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp line 1157:
>
>> 1155: const int orig_stream_length = orig_stream->length();
>> 1156: // allo
On Tue, 17 Jan 2023 11:26:12 GMT, Johan Sjölen wrote:
> Do the conversion in the share/jfr/ sub-directory and all of its files.
More manual fixes!
Fixed the review comments I found, opening this for review.
src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp line 1157:
> 1155:
19 matches
Mail list logo
