Re: RFR: 8359920: Use names for frame types in stackmaps [v5]

2025-06-24 Thread Coleen Phillimore
On Mon, 23 Jun 2025 12:06:03 GMT, Coleen Phillimore wrote: >> This uses names for frame types for stackmaps in the verifier and >> redefinition. >> Tested with tier1-7. > > Coleen Phillimore has updated the pull request incrementally with three > additional commits since the last revision: > >

Re: RFR: 8359920: Use names for frame types in stackmaps [v5]

2025-06-24 Thread David Holmes
On Mon, 23 Jun 2025 12:06:03 GMT, Coleen Phillimore wrote: >> This uses names for frame types for stackmaps in the verifier and >> redefinition. >> Tested with tier1-7. > > Coleen Phillimore has updated the pull request incrementally with three > additional commits since the last revision: > >

Re: RFR: 8359920: Use names for frame types in stackmaps [v5]

2025-06-23 Thread Coleen Phillimore
On Mon, 23 Jun 2025 12:02:43 GMT, Coleen Phillimore wrote: >> This uses names for frame types for stackmaps in the verifier and >> redefinition. >> Tested with tier1-7. > > Coleen Phillimore has updated the pull request incrementally with three > additional commits since the last revision: > >

Re: RFR: 8359920: Use names for frame types in stackmaps [v5]

2025-06-23 Thread Coleen Phillimore
> This uses names for frame types for stackmaps in the verifier and > redefinition. > Tested with tier1-7. Coleen Phillimore has updated the pull request incrementally with three additional commits since the last revision: - Update src/hotspot/share/prims/jvmtiRedefineClasses.cpp Co-aut

Re: RFR: 8359920: Use names for frame types in stackmaps [v4]

2025-06-23 Thread David Holmes
On Fri, 20 Jun 2025 15:05:03 GMT, Coleen Phillimore wrote: >> This uses names for frame types for stackmaps in the verifier and >> redefinition. >> Tested with tier1-7. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8359920: Use names for frame types in stackmaps [v4]

2025-06-20 Thread Matias Saavedra Silva
On Fri, 20 Jun 2025 15:05:03 GMT, Coleen Phillimore wrote: >> This uses names for frame types for stackmaps in the verifier and >> redefinition. >> Tested with tier1-7. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8359920: Use names for frame types in stackmaps [v4]

2025-06-20 Thread Coleen Phillimore
On Fri, 20 Jun 2025 15:05:03 GMT, Coleen Phillimore wrote: >> This uses names for frame types for stackmaps in the verifier and >> redefinition. >> Tested with tier1-7. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8359920: Use names for frame types in stackmaps [v4]

2025-06-20 Thread Coleen Phillimore
> This uses names for frame types for stackmaps in the verifier and > redefinition. > Tested with tier1-7. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: Fix tags (running more tests) - Changes: - all: https://g

Re: RFR: 8359920: Use names for frame types in stackmaps [v3]

2025-06-20 Thread Coleen Phillimore
> This uses names for frame types for stackmaps in the verifier and > redefinition. > Tested with tier1-7. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: Apply David's suggested more complete and accurate frame type names. Bei

Re: RFR: 8359920: Use names for frame types in stackmaps [v2]

2025-06-20 Thread Coleen Phillimore
> This uses names for frame types for stackmaps in the verifier and > redefinition. > Tested with tier1-7. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: Update src/hotspot/share/prims/jvmtiRedefineClasses.cpp Co-authored-

Re: RFR: 8359920: Use names for frame types in stackmaps [v2]

2025-06-20 Thread Coleen Phillimore
On Thu, 19 Jun 2025 06:24:03 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/hotspot/share/prims/jvmtiRedefineClasses.cpp >> >> Co-authored-by: David Holmes >> <62092539+dhol

Re: RFR: 8359920: Use names for frame types in stackmaps

2025-06-19 Thread Serguei Spitsyn
On Wed, 18 Jun 2025 12:13:38 GMT, Coleen Phillimore wrote: > This uses names for frame types for stackmaps in the verifier and > redefinition. > Tested with tier1-7. This looks good. I was also thinking about `frame_type` ranges but no ideas on any improvements. - Marked as review

Re: RFR: 8359920: Use names for frame types in stackmaps

2025-06-18 Thread David Holmes
On Wed, 18 Jun 2025 12:13:38 GMT, Coleen Phillimore wrote: > This uses names for frame types for stackmaps in the verifier and > redefinition. > Tested with tier1-7. src/hotspot/share/classfile/stackMapTable.hpp line 154: > 152: SAME_FRAME = 64, > 153: SAME_LOCALS_1_STACK_ITEM_FRAME =

Re: RFR: 8359920: Use names for frame types in stackmaps

2025-06-18 Thread Matias Saavedra Silva
On Wed, 18 Jun 2025 12:13:38 GMT, Coleen Phillimore wrote: > This uses names for frame types for stackmaps in the verifier and > redefinition. > Tested with tier1-7. LGTM, thanks! - Marked as reviewed by matsaave (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25870#pullr

Re: RFR: 8359920: Use names for frame types in stackmaps

2025-06-18 Thread Johan Sjölen
On Wed, 18 Jun 2025 12:13:38 GMT, Coleen Phillimore wrote: > This uses names for frame types for stackmaps in the verifier and > redefinition. > Tested with tier1-7. Marked as reviewed by jsjolen (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25870#pullrequestreview-293