Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP [v3]

2025-06-06 Thread Kevin Walls
> Doc-only cleanup, not part of the API/spec. > > Remove link to the very old reference implementation of JMXMP in the Javadoc. > This may misleadingly imply it is a supported part of the JDK. Kevin Walls has updated the pull request incrementally with one additional commit since the last revi

Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP [v2]

2025-06-06 Thread Kevin Walls
> Doc-only cleanup, not part of the API/spec. > > Remove link to the very old reference implementation of JMXMP in the Javadoc. > This may misleadingly imply it is a supported part of the JDK. Kevin Walls has updated the pull request incrementally with one additional commit since the last revi

Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP

2025-06-06 Thread Kevin Walls
On Fri, 6 Jun 2025 07:54:38 GMT, Kevin Walls wrote: > Doc-only cleanup, not part of the API/spec. > > Remove link to the very old reference implementation of JMXMP in the Javadoc. > This may misleadingly imply it is a supported part of the JDK. While updating, I now see this as problematic: "

Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP

2025-06-06 Thread Kevin Walls
On Fri, 6 Jun 2025 08:44:05 GMT, Alan Bateman wrote: >>> What would you think about dropping the sentence "The JMX Remote API allows >>> the use of different type of connectors" and drop "User-defined" from the >>> last list item >> >> Yes that's fine. As is "User-defined connector protocols.

Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP

2025-06-06 Thread Alan Bateman
On Fri, 6 Jun 2025 08:40:26 GMT, Kevin Walls wrote: > As is "User-defined connector protocols..." -> "Other connector protocols..." I think that would be okay. - PR Review Comment: https://git.openjdk.org/jdk/pull/25670#discussion_r2131785164

Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP

2025-06-06 Thread Kevin Walls
On Fri, 6 Jun 2025 08:35:13 GMT, Daniel Fuchs wrote: >> What would you think about dropping the sentence "The JMX Remote API allows >> the use of different type of connectors" and drop "User-defined" from the >> last list item? Doing that makes it much easier to say that the RMI >> Connector

Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP

2025-06-06 Thread Daniel Fuchs
On Fri, 6 Jun 2025 08:31:31 GMT, Alan Bateman wrote: >> src/java.management/share/classes/javax/management/remote/package-info.java >> line 56: >> >>> 54: * JMXConnectorFactory} and, optionally, the Generic Connector >>> 55: * (not part of this bundle, see note below). >>> 56: *

Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP

2025-06-06 Thread Alan Bateman
On Fri, 6 Jun 2025 08:18:16 GMT, Daniel Fuchs wrote: >> Doc-only cleanup, not part of the API/spec. >> >> Remove link to the very old reference implementation of JMXMP in the >> Javadoc. This may misleadingly imply it is a supported part of the JDK. > > src/java.management/share/classes/javax/

Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP

2025-06-06 Thread Daniel Fuchs
On Fri, 6 Jun 2025 07:54:38 GMT, Kevin Walls wrote: > Doc-only cleanup, not part of the API/spec. > > Remove link to the very old reference implementation of JMXMP in the Javadoc. > This may misleadingly imply it is a supported part of the JDK. src/java.management/share/classes/javax/manageme

Re: RFR: 8358701: Java API docs for javax.management.remote should not link to JMXMP

2025-06-06 Thread Kevin Walls
On Fri, 6 Jun 2025 07:54:38 GMT, Kevin Walls wrote: > Doc-only cleanup, not part of the API/spec. > > Remove link to the very old reference implementation of JMXMP in the Javadoc. > This may misleadingly imply it is a supported part of the JDK. Existing docs: https://docs.oracle.com/en/java/j