Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-14 Thread Chris Plummer
On Thu, 6 Feb 2025 22:44:48 GMT, Chris Plummer wrote: >> Cleanup SA JavaThread support. Details in first comment: >> >> Testing: >> - Tier1 >> - Tier2 svc >> - Tier3 >> - Tier5 svc >> - Local testing of debuggee using graal java compiler threads. Verified that >> the compiler threads shows up i

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-11 Thread Serguei Spitsyn
On Tue, 11 Feb 2025 23:16:04 GMT, Chris Plummer wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java >> line 54: >> >>> 52: private static long oopPtrSize; >>> 53: >>> 54: // For accessing platform dependent functionality >> >> Nit: It is better to have do

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-11 Thread Chris Plummer
On Tue, 11 Feb 2025 23:15:38 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update comments > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ThreadStackTrace.java > line 51: >

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-11 Thread Chris Plummer
On Tue, 11 Feb 2025 23:11:50 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update comments > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java > line 54: > >> 5

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-11 Thread Serguei Spitsyn
On Thu, 6 Feb 2025 22:44:48 GMT, Chris Plummer wrote: >> Cleanup SA JavaThread support. Details in first comment: >> >> Testing: >> - Tier1 >> - Tier2 svc >> - Tier3 >> - Tier5 svc >> - Local testing of debuggee using graal java compiler threads. Verified that >> the compiler threads shows up i

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-11 Thread Serguei Spitsyn
On Thu, 6 Feb 2025 22:44:48 GMT, Chris Plummer wrote: >> Cleanup SA JavaThread support. Details in first comment: >> >> Testing: >> - Tier1 >> - Tier2 svc >> - Tier3 >> - Tier5 svc >> - Local testing of debuggee using graal java compiler threads. Verified that >> the compiler threads shows up i

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-10 Thread Chris Plummer
On Mon, 10 Feb 2025 17:49:11 GMT, Kevin Walls wrote: > I think we need a HiddenJavaThread class, and "visibility" cannot just be a > boolean field in JavaThread, because virtualConstructor.addMapping wants a > mapping to a class that will already know whether it's hidden. > As I just learned f

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-10 Thread Kevin Walls
On Thu, 6 Feb 2025 22:44:48 GMT, Chris Plummer wrote: >> Cleanup SA JavaThread support. Details in first comment: >> >> Testing: >> - Tier1 >> - Tier2 svc >> - Tier3 >> - Tier5 svc >> - Local testing of debuggee using graal java compiler threads. Verified that >> the compiler threads shows up i

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-06 Thread Chris Plummer
> Cleanup SA JavaThread support. Details in first comment: > > Testing: > - Tier1 > - Tier2 svc > - Tier3 > - Tier5 svc > - Local testing of debuggee using graal java compiler threads. Verified that > the compiler threads shows up in jstack output if the property is set. Chris Plummer has update

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA

2025-02-04 Thread Chris Plummer
On Wed, 5 Feb 2025 05:00:14 GMT, David Holmes wrote: >> Cleanup SA JavaThread support. Details in first comment: >> >> Testing: >> - Tier1 >> - Tier2 svc >> - Tier3 >> - Tier5 svc >> - Local testing of debuggee using graal java compiler threads. Verified that >> the compiler threads shows up in

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA

2025-02-04 Thread David Holmes
On Wed, 5 Feb 2025 04:18:14 GMT, Chris Plummer wrote: > Cleanup SA JavaThread support. Details in first comment: > > Testing: > - Tier1 > - Tier2 svc > - Tier3 > - Tier5 svc > - Local testing of debuggee using graal java compiler threads. Verified that > the compiler threads shows up in jstack

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA

2025-02-04 Thread Chris Plummer
On Wed, 5 Feb 2025 04:18:14 GMT, Chris Plummer wrote: > Cleanup SA JavaThread support. Details in first comment: > > Testing: > - Tier1 > - Tier2 svc > - Tier3 > - Tier5 svc > - Local testing of debuggee using graal java compiler threads. Verified that > the compiler threads shows up in jstack