Re: RFR: 8344009: Improve compiler memory statistics [v8]

2025-03-03 Thread Roberto Castañeda Lozano
On Mon, 3 Mar 2025 10:41:16 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >> >

Re: RFR: 8344009: Improve compiler memory statistics [v8]

2025-03-03 Thread Thomas Stuefe
> Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Tracking Arena memory movement is not trivial since one needs

Re: RFR: 8344009: Improve compiler memory statistics [v7]

2025-03-03 Thread Thomas Stuefe
On Mon, 3 Mar 2025 09:17:03 GMT, Roberto Castañeda Lozano wrote: > Thanks for addressing my comments! The latest changeset looks good (modulo > unnecessary changes in `ostream.hpp`) and passes all tier1-5 tests in > Oracle's test pipeline. Many thanks, @robcasloz ! I also merged master and wi

Re: RFR: 8344009: Improve compiler memory statistics [v7]

2025-03-03 Thread Roberto Castañeda Lozano
On Sun, 2 Mar 2025 07:20:58 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >> >

Re: RFR: 8344009: Improve compiler memory statistics [v7]

2025-03-01 Thread Thomas Stuefe
> Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Tracking Arena memory movement is not trivial since one needs

Re: RFR: 8344009: Improve compiler memory statistics

2025-03-01 Thread Thomas Stuefe
On Wed, 26 Feb 2025 13:00:51 GMT, Roberto Castañeda Lozano wrote: >>> > @robcasloz I identified and hopefully fixed a small issue that hit the >>> > "disabled" path. Turns out we allocate arena chunks a lot more frequently >>> > than I thought, and the new unconditional call to Thread::current

Re: RFR: 8344009: Improve compiler memory statistics [v6]

2025-03-01 Thread Thomas Stuefe
On Thu, 27 Feb 2025 10:11:37 GMT, Roberto Castañeda Lozano wrote: >> Thomas Stuefe has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - feedback ashu >> - feedback roberto >> - final-statistics-switch >> - performance fix >> - remove

Re: RFR: 8344009: Improve compiler memory statistics [v6]

2025-03-01 Thread Thomas Stuefe
On Thu, 27 Feb 2025 10:08:50 GMT, Roberto Castañeda Lozano wrote: >> Thomas Stuefe has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - feedback ashu >> - feedback roberto >> - final-statistics-switch >> - performance fix >> - remove

Re: RFR: 8344009: Improve compiler memory statistics [v6]

2025-03-01 Thread Thomas Stuefe
On Thu, 27 Feb 2025 10:04:04 GMT, Roberto Castañeda Lozano wrote: >> Thomas Stuefe has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - feedback ashu >> - feedback roberto >> - final-statistics-switch >> - performance fix >> - remove

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-28 Thread Thomas Stuefe
On Wed, 26 Feb 2025 04:17:54 GMT, Ashutosh Mehra wrote: >> We are only interested in a rise that rose significantly above **both** the >> start and end point of the measurements. >> >> E.g.: >> - if we have this: start = 0, end = 20MB, peak = 20MB, this is not a >> temporary peak and we alrea

Re: RFR: 8344009: Improve compiler memory statistics [v6]

2025-02-28 Thread Thomas Stuefe
On Wed, 26 Feb 2025 12:33:14 GMT, Roberto Castañeda Lozano wrote: >> Thomas Stuefe has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - feedback ashu >> - feedback roberto >> - final-statistics-switch >> - performance fix >> - remove

Re: RFR: 8344009: Improve compiler memory statistics [v6]

2025-02-27 Thread Roberto Castañeda Lozano
On Tue, 25 Feb 2025 16:43:21 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >>

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-26 Thread Thomas Stuefe
On Wed, 26 Feb 2025 13:00:51 GMT, Roberto Castañeda Lozano wrote: >>> > @robcasloz I identified and hopefully fixed a small issue that hit the >>> > "disabled" path. Turns out we allocate arena chunks a lot more frequently >>> > than I thought, and the new unconditional call to Thread::current

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-26 Thread Roberto Castañeda Lozano
On Mon, 24 Feb 2025 08:56:51 GMT, Roberto Castañeda Lozano wrote: >>> @robcasloz I identified and hopefully fixed a small issue that hit the >>> "disabled" path. Turns out we allocate arena chunks a lot more frequently >>> than I thought, and the new unconditional call to Thread::current() in

Re: RFR: 8344009: Improve compiler memory statistics [v6]

2025-02-26 Thread Roberto Castañeda Lozano
On Tue, 25 Feb 2025 16:43:21 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >>

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-25 Thread Ashutosh Mehra
On Tue, 25 Feb 2025 16:39:14 GMT, Thomas Stuefe wrote: >>> > @robcasloz I identified and hopefully fixed a small issue that hit the >>> > "disabled" path. Turns out we allocate arena chunks a lot more frequently >>> > than I thought, and the new unconditional call to Thread::current() in >>> >

Re: RFR: 8344009: Improve compiler memory statistics [v6]

2025-02-25 Thread Ashutosh Mehra
On Tue, 25 Feb 2025 16:43:21 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >>

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-25 Thread Ashutosh Mehra
On Tue, 25 Feb 2025 16:13:48 GMT, Thomas Stuefe wrote: >> src/hotspot/share/compiler/compilationMemStatInternals.hpp line 160: >> >>> 158: void init(T v){ start = cur = peak = v; } >>> 159: void update(T v) { cur = v; if (v > peak) peak = v; } >>> 160: dT end_delta() con

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-25 Thread Thomas Stuefe
On Tue, 25 Feb 2025 06:34:29 GMT, Ashutosh Mehra wrote: >> Thomas Stuefe has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new c

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-25 Thread Thomas Stuefe
On Tue, 25 Feb 2025 16:13:59 GMT, Thomas Stuefe wrote: >> src/hotspot/share/compiler/compilationMemStatInternals.hpp line 92: >> >>> 90: >>> 91: // A very simple fixed-width FIFO buffer, used for the phase timeline >>> 92: template >> >> Would `size` be a better name than `max`? > > ok change

Re: RFR: 8344009: Improve compiler memory statistics [v6]

2025-02-25 Thread Thomas Stuefe
> Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Tracking Arena memory movement is not trivial since one needs

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-25 Thread Thomas Stuefe
On Mon, 24 Feb 2025 08:56:51 GMT, Roberto Castañeda Lozano wrote: >>> @robcasloz I identified and hopefully fixed a small issue that hit the >>> "disabled" path. Turns out we allocate arena chunks a lot more frequently >>> than I thought, and the new unconditional call to Thread::current() in

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-25 Thread Thomas Stuefe
On Tue, 25 Feb 2025 06:03:21 GMT, Ashutosh Mehra wrote: >> Thomas Stuefe has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new c

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-25 Thread Thomas Stuefe
On Tue, 25 Feb 2025 05:57:28 GMT, Ashutosh Mehra wrote: >> Thomas Stuefe has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new c

Re: RFR: 8344009: Improve compiler memory statistics [v5]

2025-02-25 Thread Thomas Stuefe
> Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Tracking Arena memory movement is not trivial since one needs

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-25 Thread Thomas Stuefe
On Mon, 24 Feb 2025 10:19:42 GMT, Roberto Castañeda Lozano wrote: >> Thomas Stuefe has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains on

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-25 Thread Thomas Stuefe
On Mon, 24 Feb 2025 10:10:50 GMT, Roberto Castañeda Lozano wrote: >> Thomas Stuefe has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains on

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-24 Thread Ashutosh Mehra
On Thu, 20 Feb 2025 13:14:34 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >>

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-24 Thread Roberto Castañeda Lozano
On Thu, 20 Feb 2025 13:14:34 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >>

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-24 Thread Roberto Castañeda Lozano
On Thu, 20 Feb 2025 13:14:34 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >>

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-24 Thread Roberto Castañeda Lozano
On Thu, 20 Feb 2025 13:14:34 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >>

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-24 Thread Roberto Castañeda Lozano
On Thu, 20 Feb 2025 13:59:57 GMT, Roberto Castañeda Lozano wrote: > > @robcasloz I identified and hopefully fixed a small issue that hit the > > "disabled" path. Turns out we allocate arena chunks a lot more frequently > > than I thought, and the new unconditional call to Thread::current() in

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-20 Thread Roberto Castañeda Lozano
On Wed, 19 Feb 2025 09:49:54 GMT, Roberto Castañeda Lozano wrote: >>> > Hi Thomas, this looks very useful, thanks! I will run some >>> > Oracle-internal functional and performance testing and come back with the >>> > results next week. >>> >>> Functional test results (Oracle internal tier1-ti

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-20 Thread Thomas Stuefe
On Wed, 19 Feb 2025 09:49:54 GMT, Roberto Castañeda Lozano wrote: >>> > Hi Thomas, this looks very useful, thanks! I will run some >>> > Oracle-internal functional and performance testing and come back with the >>> > results next week. >>> >>> Functional test results (Oracle internal tier1-ti

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-20 Thread Thomas Stuefe
> Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Tracking Arena memory movement is not trivial since one needs

Re: RFR: 8344009: Improve compiler memory statistics [v3]

2025-02-20 Thread Thomas Stuefe
> Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Tracking Arena memory movement is not trivial since one needs

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-19 Thread Roberto Castañeda Lozano
On Wed, 19 Feb 2025 06:35:38 GMT, Thomas Stuefe wrote: > > > Hi Thomas, this looks very useful, thanks! I will run some > > > Oracle-internal functional and performance testing and come back with the > > > results next week. > > > > > > Functional test results (Oracle internal tier1-tier5) lo

Re: RFR: 8344009: Improve compiler memory statistics [v2]

2025-02-18 Thread Thomas Stuefe
On Fri, 14 Feb 2025 09:34:18 GMT, Thomas Stuefe wrote: >> Greetings, >> >> This is a rewrite of the Compiler Memory Statistic. The primary new feature >> is the capability to track allocations by C2 phases. This will allow for a >> much faster, more thorough analysis of footprint issues. >>

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-18 Thread Thomas Stuefe
On Tue, 18 Feb 2025 10:07:30 GMT, Roberto Castañeda Lozano wrote: > > Hi Thomas, this looks very useful, thanks! I will run some Oracle-internal > > functional and performance testing and come back with the results next week. > > Functional test results (Oracle internal tier1-tier5) look good.

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-18 Thread Roberto Castañeda Lozano
On Fri, 14 Feb 2025 08:55:26 GMT, Roberto Castañeda Lozano wrote: > Hi Thomas, this looks very useful, thanks! I will run some Oracle-internal > functional and performance testing and come back with the results next week. Functional test results (Oracle internal tier1-tier5) look good. I meas

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-17 Thread Johan Sjölen
On Fri, 14 Feb 2025 06:37:55 GMT, Thomas Stuefe wrote: > We also save a copy of the counters to a global table that contains the N > most expensive compilations. That table will be printed when one uses jcmd > Compiler.memory. We also print it into the hs-err file. This is a new tool for me,

Re: RFR: 8344009: Improve compiler memory statistics [v2]

2025-02-14 Thread Thomas Stuefe
> Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Tracking Arena memory movement is not trivial since one needs

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-14 Thread Roberto Castañeda Lozano
On Sat, 8 Feb 2025 06:56:40 GMT, Thomas Stuefe wrote: > Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Track

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-14 Thread Roberto Castañeda Lozano
On Sat, 8 Feb 2025 06:56:40 GMT, Thomas Stuefe wrote: > Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Track

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-13 Thread Thomas Stuefe
On Sat, 8 Feb 2025 06:56:40 GMT, Thomas Stuefe wrote: > Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Track