On Mon, 6 Jan 2025 13:47:35 GMT, Coleen Phillimore wrote:
>> Yes, we are.
>
> I had a little experiment.
>
> extern "C" int printf(const char *,...);
> int main() {
> unsigned short ss = 0x8000;
> printf("does unsigned sign extend to int? %d\n", int(ss));
> }
IMO you could just call `as_int
On Mon, 6 Jan 2025 13:44:27 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/ci/ciFlags.cpp line 95:
>>
>>> 93: // ciFlags::print
>>> 94: void ciFlags::print(outputStream* st) {
>>> 95: st->print(" flags=%x", _flags.as_unsigned_short());
>>
>> Here, and elsewhere, are we relying on an impli
On Mon, 6 Jan 2025 03:47:05 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix more copyrights.
>
> src/hotspot/share/ci/ciFlags.hpp line 71:
>
>> 69:
>> 70: // Conversion
>> 71: jint
On Mon, 6 Jan 2025 03:44:09 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix more copyrights.
>
> src/hotspot/share/ci/ciFlags.cpp line 95:
>
>> 93: // ciFlags::print
>> 94: void ciFlags:
On Fri, 3 Jan 2025 22:00:34 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
