Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-22 Thread Alan Bateman
On Wed, 21 Aug 2024 13:42:18 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread Joakim Nordström
On Wed, 21 Aug 2024 22:27:27 GMT, David Holmes wrote: >> I want to provide advice for how this API should be used. >> >> The "recent period of time observed" is vague (Who's the observer? Who >> decides the "recent period"? The API user or the JVM?). In essence it is the >> time between two co

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread David Holmes
On Wed, 21 Aug 2024 13:49:08 GMT, Joakim Nordström wrote: >> Ok yes maybe "not idempotent" isn't a great term here. >> Just removing that phrase, "This method is not idempotent.", this would >> still be a helpful update. > > I want to provide advice for how this API should be used. > > The "re

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread Daniel Fuchs
On Wed, 21 Aug 2024 13:42:18 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread Joakim Nordström
On Wed, 21 Aug 2024 12:25:48 GMT, Kevin Walls wrote: >> You beat me to it. We specify some methods (close, dispose, ...) as >> idempotent. Specifying a getter as non-idempotent looks very strange here. >> >> I can't tell if you are looking to specify implementation behavior (as David >> asks)

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread Joakim Nordström
> Can I get a review of this documentation update to clarify the usage of > GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and GetProcessCpuLoad. > > Calling either of these methods in quick succession can lead to > unrepresentative results due to too few data points. > > This behavior