Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v4]

2024-09-10 Thread Joakim Nordström
On Mon, 26 Aug 2024 13:54:36 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v4]

2024-09-10 Thread duke
On Mon, 26 Aug 2024 13:54:36 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v4]

2024-08-26 Thread Alan Bateman
On Mon, 26 Aug 2024 13:54:36 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-26 Thread Joakim Nordström
On Mon, 26 Aug 2024 13:51:08 GMT, Alan Bateman wrote: >> Reviewing the current implementation this seems to be the case. >> >> The `@implNote` was more meant as an explanation to why the result could be >> affected by other callers. Since the `@apiNote` also states that the >> "observation pe

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-26 Thread Alan Bateman
On Mon, 26 Aug 2024 13:46:41 GMT, Joakim Nordström wrote: >> src/jdk.management/share/classes/com/sun/management/OperatingSystemMXBean.java >> line 154: >> >>> 152: * affecting the observation period and the result. >>> 153: * >>> 154: * @implNote There is only one observation p

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-26 Thread Joakim Nordström
On Fri, 23 Aug 2024 12:01:43 GMT, Alan Bateman wrote: >> Joakim Nordström has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added implNote and made some re-arrangements > > src/jdk.management/share/classes/com/sun/management/OperatingSyste

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v4]

2024-08-26 Thread Joakim Nordström
> Can I get a review of this documentation update to clarify the usage of > GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and GetProcessCpuLoad. > > Calling either of these methods in quick succession can lead to > unrepresentative results due to too few data points. > > This behavior

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-23 Thread Alan Bateman
On Fri, 23 Aug 2024 08:49:38 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-23 Thread Kevin Walls
On Fri, 23 Aug 2024 08:49:38 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-23 Thread Joakim Nordström
On Fri, 23 Aug 2024 08:49:38 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-23 Thread Joakim Nordström
> Can I get a review of this documentation update to clarify the usage of > GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and GetProcessCpuLoad. > > Calling either of these methods in quick succession can lead to > unrepresentative results due to too few data points. > > This behavior

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-22 Thread Alan Bateman
On Wed, 21 Aug 2024 13:42:18 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread Joakim Nordström
On Wed, 21 Aug 2024 22:27:27 GMT, David Holmes wrote: >> I want to provide advice for how this API should be used. >> >> The "recent period of time observed" is vague (Who's the observer? Who >> decides the "recent period"? The API user or the JVM?). In essence it is the >> time between two co

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread David Holmes
On Wed, 21 Aug 2024 13:49:08 GMT, Joakim Nordström wrote: >> Ok yes maybe "not idempotent" isn't a great term here. >> Just removing that phrase, "This method is not idempotent.", this would >> still be a helpful update. > > I want to provide advice for how this API should be used. > > The "re

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread Daniel Fuchs
On Wed, 21 Aug 2024 13:42:18 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread Joakim Nordström
On Wed, 21 Aug 2024 12:25:48 GMT, Kevin Walls wrote: >> You beat me to it. We specify some methods (close, dispose, ...) as >> idempotent. Specifying a getter as non-idempotent looks very strange here. >> >> I can't tell if you are looking to specify implementation behavior (as David >> asks)

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v2]

2024-08-21 Thread Joakim Nordström
> Can I get a review of this documentation update to clarify the usage of > GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and GetProcessCpuLoad. > > Calling either of these methods in quick succession can lead to > unrepresentative results due to too few data points. > > This behavior

Re: RFR: 8335625: Update Javadoc for GetCpuLoad

2024-08-21 Thread Kevin Walls
On Wed, 21 Aug 2024 11:35:26 GMT, Alan Bateman wrote: >> src/jdk.management/share/classes/com/sun/management/OperatingSystemMXBean.java >> line 142: >> >>> 140: * negative value. >>> 141: * >>> 142: * This method is not idempotent. The recent period of >>> observation >> >> I

Re: RFR: 8335625: Update Javadoc for GetCpuLoad

2024-08-21 Thread Alan Bateman
On Wed, 21 Aug 2024 11:27:44 GMT, David Holmes wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> unrepr

Re: RFR: 8335625: Update Javadoc for GetCpuLoad

2024-08-21 Thread David Holmes
On Mon, 12 Aug 2024 12:33:04 GMT, Joakim Nordström wrote: > Can I get a review of this documentation update to clarify the usage of > GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and GetProcessCpuLoad. > > Calling either of these methods in quick succession can lead to > unrepresen

Re: RFR: 8335625: Update Javadoc for GetCpuLoad

2024-08-21 Thread Kevin Walls
On Mon, 12 Aug 2024 12:33:04 GMT, Joakim Nordström wrote: > Can I get a review of this documentation update to clarify the usage of > GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and GetProcessCpuLoad. > > Calling either of these methods in quick succession can lead to > unrepresen