Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun [v2]

2023-07-06 Thread Daniel Jeliński
On Thu, 6 Jul 2023 07:08:00 GMT, David Holmes wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use void* instead > > test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/libMethodExitTest.cpp > line 12

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun [v2]

2023-07-06 Thread Daniel Jeliński
On Wed, 5 Jul 2023 06:40:11 GMT, Daniel Jeliński wrote: >> Please review this test-only fix that fixes the size of variables that are >> used in methods that expect a pointer. >> >> On Windows, type `long` is 32 bits, pointers are 64 bits large. The method >> `GetThreadLocalStorage` writes a p

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun [v2]

2023-07-06 Thread David Holmes
On Wed, 5 Jul 2023 06:40:11 GMT, Daniel Jeliński wrote: >> Please review this test-only fix that fixes the size of variables that are >> used in methods that expect a pointer. >> >> On Windows, type `long` is 32 bits, pointers are 64 bits large. The method >> `GetThreadLocalStorage` writes a p

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun [v2]

2023-07-05 Thread Serguei Spitsyn
On Wed, 5 Jul 2023 06:40:11 GMT, Daniel Jeliński wrote: >> Please review this test-only fix that fixes the size of variables that are >> used in methods that expect a pointer. >> >> On Windows, type `long` is 32 bits, pointers are 64 bits large. The method >> `GetThreadLocalStorage` writes a p

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun [v2]

2023-07-05 Thread Chris Plummer
On Wed, 5 Jul 2023 06:40:11 GMT, Daniel Jeliński wrote: >> Please review this test-only fix that fixes the size of variables that are >> used in methods that expect a pointer. >> >> On Windows, type `long` is 32 bits, pointers are 64 bits large. The method >> `GetThreadLocalStorage` writes a p

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun

2023-07-04 Thread Daniel Jeliński
On Tue, 4 Jul 2023 17:33:02 GMT, Daniel Jeliński wrote: > Please review this test-only fix that fixes the size of variables that are > used in methods that expect a pointer. > > On Windows, type `long` is 32 bits, pointers are 64 bits large. The method > `GetThreadLocalStorage` writes a pointe

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun [v2]

2023-07-04 Thread Daniel Jeliński
> Please review this test-only fix that fixes the size of variables that are > used in methods that expect a pointer. > > On Windows, type `long` is 32 bits, pointers are 64 bits large. The method > `GetThreadLocalStorage` writes a pointer (64 bits) to the address given by > its parameter, whic

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun

2023-07-04 Thread David Holmes
On Tue, 4 Jul 2023 17:33:02 GMT, Daniel Jeliński wrote: > Please review this test-only fix that fixes the size of variables that are > used in methods that expect a pointer. > > On Windows, type `long` is 32 bits, pointers are 64 bits large. The method > `GetThreadLocalStorage` writes a pointe

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun

2023-07-04 Thread Kevin Walls
On Tue, 4 Jul 2023 17:33:02 GMT, Daniel Jeliński wrote: > Please review this test-only fix that fixes the size of variables that are > used in methods that expect a pointer. > > On Windows, type `long` is 32 bits, pointers are 64 bits large. The method > `GetThreadLocalStorage` writes a pointe