Re: RFR: 8305607: Remove some unused test parameters in com/sun/jdi tests [v2]

2023-04-05 Thread Leonid Mesnik
> Some tests set debugee name which is set by startUp() method. > > The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set > classpath which is not required. Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev exc

Re: RFR: 8305607: Remove some unused test parameters in com/sun/jdi tests

2023-04-05 Thread Chris Plummer
On Tue, 4 Apr 2023 20:15:41 GMT, Leonid Mesnik wrote: > Some tests set debugee name which is set by startUp() method. > > The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set > classpath which is not required. Marked as reviewed by cjplummer (Reviewer). - PR Re

Re: RFR: 8305607: Remove some unused test parameters in com/sun/jdi tests

2023-04-05 Thread Leonid Mesnik
On Wed, 5 Apr 2023 19:51:00 GMT, Chris Plummer wrote: > Do I understand correctly that this bug just caused the debuggee to appear > twice in the arguments, leading to output like the following: > > [2ms] run args: [RefTypes, RefTypes] > > In this case it was harmless because the 2nd "RefTypes

Re: RFR: 8305607: Remove some unused test parameters in com/sun/jdi tests

2023-04-05 Thread Alex Menkov
On Tue, 4 Apr 2023 20:15:41 GMT, Leonid Mesnik wrote: > Some tests set debugee name which is set by startUp() method. > > The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set > classpath which is not required. Marked as reviewed by amenkov (Reviewer). - PR Revi

Re: RFR: 8305607: Remove some unused test parameters in com/sun/jdi tests

2023-04-05 Thread Chris Plummer
On Tue, 4 Apr 2023 20:15:41 GMT, Leonid Mesnik wrote: > Some tests set debugee name which is set by startUp() method. > > The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set > classpath which is not required. Do I understand correctly that this bug just caused the debuggee

Re: RFR: 8305607: Remove some unused test parameters in com/sun/jdi tests

2023-04-04 Thread Serguei Spitsyn
On Tue, 4 Apr 2023 20:15:41 GMT, Leonid Mesnik wrote: > Some tests set debugee name which is set by startUp() method. > > The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set > classpath which is not required. Looks good. Good to know this about `TestScaffold` framework. Tha