Re: RFR: 8304685: heap-buffer-overflow in libjdwp [v2]

2023-05-12 Thread Serguei Spitsyn
On Fri, 12 May 2023 20:29:50 GMT, Kevin Walls wrote: >> Problem call to skipWhitespace in dbgsysExec >> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91 >> >> We call skipWhitespace even when the loop will terminate, should guard >> against the last skipWhitespace call on the last iteration

Re: RFR: 8304685: heap-buffer-overflow in libjdwp [v2]

2023-05-12 Thread Alex Menkov
On Fri, 12 May 2023 20:29:50 GMT, Kevin Walls wrote: >> Problem call to skipWhitespace in dbgsysExec >> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91 >> >> We call skipWhitespace even when the loop will terminate, should guard >> against the last skipWhitespace call on the last iteration

Re: RFR: 8304685: heap-buffer-overflow in libjdwp [v2]

2023-05-12 Thread Chris Plummer
On Fri, 12 May 2023 20:29:50 GMT, Kevin Walls wrote: >> Problem call to skipWhitespace in dbgsysExec >> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91 >> >> We call skipWhitespace even when the loop will terminate, should guard >> against the last skipWhitespace call on the last iteration

Re: RFR: 8304685: heap-buffer-overflow in libjdwp [v2]

2023-05-12 Thread Kevin Walls
On Fri, 12 May 2023 19:39:10 GMT, Chris Plummer wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move skipWhitespace to start > > src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 93: > >> 91: if ((i + 1

Re: RFR: 8304685: heap-buffer-overflow in libjdwp [v2]

2023-05-12 Thread Kevin Walls
> Problem call to skipWhitespace in dbgsysExec > src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91 > > We call skipWhitespace even when the loop will terminate, should guard > against the last skipWhitespace call on the last iteration. > > Could be done differently with the skipWhitespace cal