Re: RFR: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace() [v2]

2022-09-28 Thread Patricio Chilano Mateo
On Wed, 28 Sep 2022 14:43:43 GMT, Patricio Chilano Mateo wrote: >> Please review this small fix in async_get_stack_trace(). The GrowableArrays >> created to store the bci and Method* of each frame found while traversing >> the stack are allocated in the resource area of the thread that calls

Re: RFR: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace() [v2]

2022-09-28 Thread Patricio Chilano Mateo
> Please review this small fix in async_get_stack_trace(). The GrowableArrays > created to store the bci and Method* of each frame found while traversing the > stack are allocated in the resource area of the thread that calls > async_get_stack_trace(). But if the handshake is executed by the tar

Re: RFR: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()

2022-09-27 Thread Serguei Spitsyn
On Mon, 26 Sep 2022 14:23:38 GMT, Patricio Chilano Mateo wrote: > Please review this small fix in async_get_stack_trace(). The GrowableArrays > created to store the bci and Method* of each frame found while traversing the > stack are allocated in the resource area of the thread that calls > a

Re: RFR: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()

2022-09-27 Thread David Holmes
On Mon, 26 Sep 2022 14:23:38 GMT, Patricio Chilano Mateo wrote: > Please review this small fix in async_get_stack_trace(). The GrowableArrays > created to store the bci and Method* of each frame found while traversing the > stack are allocated in the resource area of the thread that calls > a

Re: RFR: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()

2022-09-27 Thread David Holmes
On Tue, 27 Sep 2022 16:09:07 GMT, Patricio Chilano Mateo wrote: >> src/hotspot/share/classfile/javaClasses.cpp line 2004: >> >>> 2002: const bool skip_hidden = !ShowHiddenFrames; >>> 2003: >>> 2004: // Pick some initial length >> >> The comment should at least hint at there being

Re: RFR: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()

2022-09-27 Thread Patricio Chilano Mateo
On Tue, 27 Sep 2022 06:48:50 GMT, David Holmes wrote: > Good find! Looks good! A couple of queries at this stage. > > Thanks. > Thanks for looking at this David. > src/hotspot/share/classfile/javaClasses.cpp line 2004: > >> 2002: const bool skip_hidden = !ShowHiddenFrames; >> 2003: >> 2

Re: RFR: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()

2022-09-26 Thread David Holmes
On Mon, 26 Sep 2022 14:23:38 GMT, Patricio Chilano Mateo wrote: > Please review this small fix in async_get_stack_trace(). The GrowableArrays > created to store the bci and Method* of each frame found while traversing the > stack are allocated in the resource area of the thread that calls > a