Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v4]

2022-08-31 Thread David Holmes
On Wed, 31 Aug 2022 12:30:24 GMT, Coleen Phillimore wrote: >> I still can't decipher what this "map" actually holds. What does the unique >> WeakHandle actually refer to? > > WeakHandles are wrappers around a pointer to an oop that has been allocated > in OopStorage. We cannot hold oops direct

Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v4]

2022-08-31 Thread Coleen Phillimore
On Wed, 31 Aug 2022 05:15:22 GMT, David Holmes wrote: >> Okay, I added your comment. > > I still can't decipher what this "map" actually holds. What does the unique > WeakHandle actually refer to? WeakHandles are wrappers around a pointer to an oop that has been allocated in OopStorage. We ca

Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v4]

2022-08-30 Thread David Holmes
On Tue, 30 Aug 2022 20:11:51 GMT, Coleen Phillimore wrote: >> src/hotspot/share/classfile/protectionDomainCache.hpp line 35: >> >>> 33: // The amount of different protection domains used is typically >>> magnitudes smaller >>> 34: // than the number of system dictionary entries (loaded classes)

Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v4]

2022-08-30 Thread Coleen Phillimore
On Tue, 30 Aug 2022 18:20:26 GMT, Ioi Lam wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> David's comments > > src/hotspot/share/classfile/protectionDomainCache.cpp line 162: > >> 160: // Purge any deleted

Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v4]

2022-08-30 Thread Ioi Lam
On Mon, 29 Aug 2022 12:24:33 GMT, Coleen Phillimore wrote: >> Please review this simple conversion for the ProtectionDomainCacheTable from >> Old Hashtable to ResourceHashtable. There are specific tests for this table >> in test/hotspot/jtreg/runtime/Dictionary and >> serviceability/dcmd/vm/D

Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v4]

2022-08-29 Thread Coleen Phillimore
> Please review this simple conversion for the ProtectionDomainCacheTable from > Old Hashtable to ResourceHashtable. There are specific tests for this table > in test/hotspot/jtreg/runtime/Dictionary and > serviceability/dcmd/vm/DictionaryStatsTest.java. > Also tested with tier1-7. Coleen Phil