On Wed, 31 Aug 2022 05:11:33 GMT, David Holmes wrote:
>> I think you should add an assert that the `protection_domain.resolve()`
>> never returns null, with a comment explaining why.
>
> I agree. In general if code is using WeakHandle's then I would expect to see
> null checks.
I added the com
On Wed, 31 Aug 2022 05:13:17 GMT, David Holmes wrote:
>> This one (not the one I removed), is called by dictionary.cpp - the pd_set
>> is a linked list of ProtectionDomainEntry, where we don't keep the
>> WeakHandle alive when looking at the value.
>
> I don't understand your point. My point is
On Mon, 29 Aug 2022 12:11:03 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/protectionDomainCache.cpp line 168:
>>
>>> 166: }
>>> 167:
>>> 168: void ProtectionDomainCacheTable::print_on(outputStream* st) {
>>
>> It is a little disconcerting that `print_on` can no longer be a `con
On Tue, 30 Aug 2022 18:13:21 GMT, Ioi Lam wrote:
>> compute_hash() is always called on a live WeakHandle so will never return
>> null.
>
> I think you should add an assert that the `protection_domain.resolve()` never
> returns null, with a comment explaining why.
I agree. In general if code is
On Mon, 29 Aug 2022 12:10:48 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/protectionDomainCache.cpp line 43:
>>
>>> 41:
>>> 42: unsigned int ProtectionDomainCacheTable::compute_hash(const WeakHandle&
>>> protection_domain) {
>>> 43: return (unsigned int)(protection_domain.res
On Mon, 29 Aug 2022 00:12:36 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> include mutexLocker.hpp for minimal build.
>
> src/hotspot/share/classfile/protectionDomainCache.cpp line 42:
>
>
On Fri, 26 Aug 2022 17:07:54 GMT, Coleen Phillimore wrote:
>> Please review this simple conversion for the ProtectionDomainCacheTable from
>> Old Hashtable to ResourceHashtable. There are specific tests for this table
>> in test/hotspot/jtreg/runtime/Dictionary and
>> serviceability/dcmd/vm/D
On Fri, 26 Aug 2022 17:07:54 GMT, Coleen Phillimore wrote:
>> Please review this simple conversion for the ProtectionDomainCacheTable from
>> Old Hashtable to ResourceHashtable. There are specific tests for this table
>> in test/hotspot/jtreg/runtime/Dictionary and
>> serviceability/dcmd/vm/D
> Please review this simple conversion for the ProtectionDomainCacheTable from
> Old Hashtable to ResourceHashtable. There are specific tests for this table
> in test/hotspot/jtreg/runtime/Dictionary and
> serviceability/dcmd/vm/DictionaryStatsTest.java.
> Also tested with tier1-7.
Coleen Phil
