Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-16 Thread Fei Yang
On Fri, 14 Oct 2022 15:39:41 GMT, Roman Kennke wrote: >>> > > > > > Here is the basic support for RISC-V: >>> > > > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch >>> > > > > > -- I adapted this from AArch64 changes, and tested it very >>> > > > > > lightly. @RealFYang, can

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Roman Kennke
On Fri, 14 Oct 2022 14:53:57 GMT, Fei Yang wrote: > > > > > > > Here is the basic support for RISC-V: > > > > > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > > > > > -- I adapted this from AArch64 changes, and tested it very > > > > > > > lightly. @RealFYang, can I le

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Fei Yang
On Fri, 14 Oct 2022 14:39:01 GMT, Roman Kennke wrote: > > > > > > Here is the basic support for RISC-V: > > > > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > > > > -- I adapted this from AArch64 changes, and tested it very lightly. > > > > > > @RealFYang, can I leave

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Roman Kennke
On Fri, 14 Oct 2022 14:32:57 GMT, Fei Yang wrote: > > > > > Here is the basic support for RISC-V: > > > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > > > -- I adapted this from AArch64 changes, and tested it very lightly. > > > > > @RealFYang, can I leave the testing

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Fei Yang
On Fri, 14 Oct 2022 14:26:20 GMT, Roman Kennke wrote: > > > > Here is the basic support for RISC-V: > > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > > -- I adapted this from AArch64 changes, and tested it very lightly. > > > > @RealFYang, can I leave the testing and

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Roman Kennke
On Fri, 14 Oct 2022 13:45:07 GMT, Fei Yang wrote: > > > Here is the basic support for RISC-V: > > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > > -- I adapted this from AArch64 changes, and tested it very lightly. > > > @RealFYang, can I leave the testing and follow up fi

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-14 Thread Fei Yang
On Fri, 14 Oct 2022 01:19:27 GMT, Fei Yang wrote: > > Here is the basic support for RISC-V: > > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > -- I adapted this from AArch64 changes, and tested it very lightly. > > @RealFYang, can I leave the testing and follow up fixes to y

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-13 Thread Fei Yang
On Wed, 12 Oct 2022 11:26:16 GMT, Aleksey Shipilev wrote: > Here is the basic support for RISC-V: > https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch > > -- I adapted this from AArch64 changes, and tested it very lightly. > @RealFYang, can I leave the testing and follow up fixes t

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-13 Thread Roman Kennke
On Tue, 11 Oct 2022 20:41:57 GMT, Robbin Ehn wrote: > Regarding benchmarks, is it possible to get some indication what > fast-locking+lillput result will be? FinagleHttp seems to suffer a bit, will > Lillput give some/all of that back, or more? That particular benchmark, as some others, exhibi

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-12 Thread Aleksey Shipilev
On Tue, 11 Oct 2022 20:01:32 GMT, Roman Kennke wrote: >> This change replaces the current stack-locking implementation with a >> fast-locking scheme that retains the advantages of stack-locking (namely >> fast locking in uncontended code-paths), while avoiding the overload of the >> mark word.

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-11 Thread Robbin Ehn
On Tue, 11 Oct 2022 20:01:32 GMT, Roman Kennke wrote: >> This change replaces the current stack-locking implementation with a >> fast-locking scheme that retains the advantages of stack-locking (namely >> fast locking in uncontended code-paths), while avoiding the overload of the >> mark word.

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-11 Thread Roman Kennke
On Tue, 11 Oct 2022 13:25:30 GMT, Aleksey Shipilev wrote: >> Roman Kennke has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/fast-locking' into fast-locking >> - Re-use r0 in call to unlock_object() >

Re: RFR: 8291555: Replace stack-locking with fast-locking [v3]

2022-10-11 Thread Roman Kennke
> This change replaces the current stack-locking implementation with a > fast-locking scheme that retains the advantages of stack-locking (namely fast > locking in uncontended code-paths), while avoiding the overload of the mark > word. That overloading causes massive problems with Lilliput, bec