On Thu, 21 Jul 2022 19:18:28 GMT, Zhengyu Gu wrote:
> I pushed update that removed the block, could you please run it through
> Oracle's internal tests?
I think, you can run all the needed tests by yourself.
But I'll also submit mach5 jobs to be safe.
-
PR: https://git.openjdk.org
On Thu, 21 Jul 2022 13:33:01 GMT, Zhengyu Gu wrote:
>> Hi, it was added because some tests were failing. With the concurrent
>> posting, we were missing events and flushing them made the tests pass.
>
>> Hi, it was added because some tests were failing. With the concurrent
>> posting, we were
On Thu, 21 Jul 2022 13:33:01 GMT, Zhengyu Gu wrote:
>> Hi, it was added because some tests were failing. With the concurrent
>> posting, we were missing events and flushing them made the tests pass.
>
>> Hi, it was added because some tests were failing. With the concurrent
>> posting, we were
On Thu, 21 Jul 2022 13:33:01 GMT, Zhengyu Gu wrote:
>> Hi, it was added because some tests were failing. With the concurrent
>> posting, we were missing events and flushing them made the tests pass.
>
>> Hi, it was added because some tests were failing. With the concurrent
>> posting, we were
On Thu, 21 Jul 2022 13:33:01 GMT, Zhengyu Gu wrote:
> > Hi, it was added because some tests were failing. With the concurrent
> > posting, we were missing events and flushing them made the tests pass.
>
> Thanks, @coleenp Can you recall what were those tests?
>
> I removed the block and passed
On Thu, 21 Jul 2022 13:18:25 GMT, Coleen Phillimore wrote:
> Hi, it was added because some tests were failing. With the concurrent
> posting, we were missing events and flushing them made the tests pass.
Thanks, @coleenp
Can you recall what were those tests?
I removed the block and passed vm
On Mon, 18 Jul 2022 23:12:00 GMT, Zhengyu Gu wrote:
>> Currently, jdi only check and process class unloading event when it detects
>> a new GC cycle.
>>
>> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting
>> class events can overlap with GC finish event, that results,
On Wed, 20 Jul 2022 18:30:43 GMT, Zhengyu Gu wrote:
> > get_objects_with_tags
>
> @sspitsyn Good catch!
>
> I believe it should be synchronized if `JvmtiEnv::GetObjectsWithTags()` call
> can overlap disable/enable `ObjectFree` event.
>
> But it raises a question: why it needs `remove_and_post
On Wed, 20 Jul 2022 16:53:39 GMT, Serguei Spitsyn wrote:
> get_objects_with_tags
@sspitsyn Good catch!
I believe it should be synchronized if `JvmtiEnv::GetObjectsWithTags()` call
can overlap disable/enable `ObjectFree` event.
But it raises a question: why it needs `remove_and_post_dead_objec
On Wed, 20 Jul 2022 16:57:21 GMT, Chris Plummer wrote:
> > I see my comment as pending but have no idea why it was not posted.
>
> Your comment is pending because you clicked on "Start a review" instead of
> "Add single comment", and then never finished the review by clicking on
> "Review chan
On Wed, 20 Jul 2022 16:53:39 GMT, Serguei Spitsyn wrote:
> I see my comment as pending but have no idea why it was not posted.
Your comment is pending because you clicked on "Start a review" instead of "Add
single comment", and then never finished the review by clicking on "Review
changes".
-
On Mon, 18 Jul 2022 23:12:00 GMT, Zhengyu Gu wrote:
>> Currently, jdi only check and process class unloading event when it detects
>> a new GC cycle.
>>
>> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting
>> class events can overlap with GC finish event, that results,
On Mon, 18 Jul 2022 23:12:00 GMT, Zhengyu Gu wrote:
>> Currently, jdi only check and process class unloading event when it detects
>> a new GC cycle.
>>
>> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting
>> class events can overlap with GC finish event, that results,
On Mon, 18 Jul 2022 23:12:00 GMT, Zhengyu Gu wrote:
>> Currently, jdi only check and process class unloading event when it detects
>> a new GC cycle.
>>
>> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting
>> class events can overlap with GC finish event, that results,
> Currently, jdi only check and process class unloading event when it detects a
> new GC cycle.
>
> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting
> class events can overlap with GC finish event, that results, sometimes, it
> only captures partial or even empty unload
15 matches
Mail list logo
