On Wed, 15 Nov 2023 06:22:58 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request incrementally with one ad
On Wed, 15 Nov 2023 06:22:58 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request incrementally with one ad
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
Thomas Stuefe has updated the pull request incrementally with one additional
commit since the last revision:
feedback shade
--
On Tue, 14 Nov 2023 15:03:42 GMT, Aleksey Shipilev wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' into
>> JDK-8318671-Potential-uninitialized-uintx-value-after-
On Mon, 13 Nov 2023 13:33:26 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request with a new target base du
On Mon, 13 Nov 2023 13:33:26 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request with a new target base du
On Mon, 13 Nov 2023 11:51:30 GMT, Tobias Hartmann wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix Windows build
>
> I think this is ready for integration given that both @dholmes-ora and
> @jdksjolen are okay
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
Thomas Stuefe has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains six co
On Mon, 13 Nov 2023 11:51:30 GMT, Tobias Hartmann wrote:
> I think this is ready for integration given that both @dholmes-ora and
> @jdksjolen are okay with it.
Well, they did not approve yet; @jdksjolen or @dholmes-ora, if you are happy
with this, could you hit the big green button please?
-
On Thu, 26 Oct 2023 16:17:14 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request incrementally with one ad
On Thu, 26 Oct 2023 16:17:14 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request incrementally with one ad
On Mon, 30 Oct 2023 10:32:17 GMT, Thomas Stuefe wrote:
>This code would gain IMHO by being dumbed down
Agreed, seems like it's had a lot of "just one more feature" commits over time.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16335#discussion_r1376144551
On Mon, 30 Oct 2023 10:13:02 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix Windows build
>
> test/hotspot/jtreg/compiler/compilercontrol/commands/MemStatTest.java line 3:
>
>> 1: /*
>> 2:
On Mon, 30 Oct 2023 10:22:06 GMT, Johan Sjölen wrote:
> Ouch, I just realized that we can't differentiate between being provided with
> the literal number 2 and `MemStatAction::print` anymore since you moved the
> literal number parsing into this function. That means that we can't set
> `print
On Mon, 30 Oct 2023 09:55:35 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix Windows build
>
> src/hotspot/share/compiler/compilerOracle.cpp line 654:
>
>> 652: IF_ENUM_STRING("print", {
On Thu, 26 Oct 2023 16:17:14 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request incrementally with one ad
On Thu, 26 Oct 2023 08:55:49 GMT, Thomas Stuefe wrote:
>> Okay I'll butt out. The comment doesn't make sense to me.
>
> @dholmes-ora Sorry if I came across as flippant; that was not my intention.
> If you can stomach it, I rewrote the patch to be hopefully easier to read.
> Thanks.
No I didn't
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
Thomas Stuefe has updated the pull request incrementally with one additional
commit since the last revision:
Fix Windows build
On Thu, 26 Oct 2023 08:58:13 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request incrementally with two ad
On Wed, 25 Oct 2023 22:16:03 GMT, David Holmes wrote:
>>> If "omitting value means 'collect'" then why do we not simply set value =
>>> (uintx)MemStatAction::collect ? Otherwise what is that message supposed to
>>> mean?
>>
>> We only enter this function if a value for this command had been gi
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
Thomas Stuefe has updated the pull request incrementally with two additional
commits since the last revision:
- remove tab
- Ma
On Tue, 24 Oct 2023 12:26:46 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/compiler/compilerOracle.cpp line 650:
>>
>>> 648: } else {
>>> 649: jio_snprintf(errorbuf, buf_size, "MemStat: invalid value
>>> expected 'collect' or 'print' (omitting value means 'collect')");
>>> 650:
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
Thomas Stuefe has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the
On Tue, 24 Oct 2023 10:26:32 GMT, David Holmes wrote:
> If "omitting value means 'collect'" then why do we not simply set value =
> (uintx)MemStatAction::collect ? Otherwise what is that message supposed to
> mean?
We only enter this function if a value for this command had been given
(`-XX:C
On Tue, 24 Oct 2023 07:08:07 GMT, Thomas Stuefe wrote:
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
src/hotspot/share/compiler/compilerOracle.cpp line 650:
> 648: } else
When using 'MemStat' CompileCommand, we accidentally register the command if an
invalid suboption had been specified. Fixed, added regression test (verified).
-
Commit messages:
- JDK-8318671-Potential-uninitialized-uintx-value-after-JDK-8317683
Changes: https://git.openjdk.org/jdk
26 matches
Mail list logo
