Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-28 Thread Thomas Stuefe
On Fri, 27 Oct 2023 20:20:49 GMT, Gerard Ziemski wrote: >> Thomas Stuefe has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix spelling >> - timeout fuse >> - Feedback Johan > > src/hotspot/share/services/memMapPrinter.cpp line 95: >

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-28 Thread Thomas Stuefe
On Fri, 27 Oct 2023 15:42:06 GMT, Gerard Ziemski wrote: >> Thomas Stuefe has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix spelling >> - timeout fuse >> - Feedback Johan > > Taking a look... @gerard-ziemski @jdksjolen I take thi

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-28 Thread Thomas Stuefe
On Fri, 27 Oct 2023 22:01:07 GMT, Gerard Ziemski wrote: >> Thomas Stuefe has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix spelling >> - timeout fuse >> - Feedback Johan > > src/hotspot/share/services/memMapPrinter.cpp line 294:

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Thomas Stuefe
On Fri, 27 Oct 2023 17:29:23 GMT, Gerard Ziemski wrote: > I really like this feature, hope the other platforms can be done as well. (I > am also really looking forward to seeing how you did the "malloc" version) > > I think we should set the user expectations correctly and say somewhere that >

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Gerard Ziemski
On Fri, 27 Oct 2023 12:28:51 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Gerard Ziemski
On Fri, 27 Oct 2023 12:28:51 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Gerard Ziemski
On Fri, 27 Oct 2023 12:28:51 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Thomas Stuefe
> Analysts and supporters often use /proc/xx/maps to make sense of the memory > footprint of a process. > > Interpreting the memory map correctly can help when used as a complement to > other tools (e.g. NMT). There even exist tools out there that attempt to > annotate the process memory map wi