On Thu, 28 Sep 2023 02:11:45 GMT, David Holmes wrote:
>> This is existing field in the class.
>> There are a number (45) of misspelled "referer" in the lib, including some
>> public methods (like getReferer() in line 140).
>> If you think it makes sense to fix the, I can file a separate CR for t
On Wed, 27 Sep 2023 21:51:38 GMT, Alex Menkov wrote:
>> test/lib/jdk/test/lib/hprof/model/Root.java line 145:
>>
>>> 143:
>>> 144: public long getReferrerId() {
>>> 145: return refererId;
>>
>> Spelling: `referrerId`
>
> This is existing field in the class.
> There are a number (45
On Wed, 27 Sep 2023 07:11:26 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> David's feedback
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/HeapDump/VtreadInHeapDump.java
> line 1:
>
>> 1:
> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
> stack references
> The change:
> - reorganize thread-related code/prepare it to use for unmounted vthreads:
> - new ThreadDumper class caches stack frames, thread serial num, frame
> serial number (trace serial number
