On Fri, 22 Sep 2023 00:01:58 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Fri, 22 Sep 2023 00:01:58 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Thu, 21 Sep 2023 20:28:02 GMT, Alex Menkov wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add more test cases
>
> test/jdk/com/sun/jdi/JdwpNetProps.java line 89:
>
>> 87: .preferIPv4S
> Please consider this fix for
> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
> only handled `-Djava.net.preferIPv6Addresses=true` and
> `-Djava.net.preferIPv6Addresses=false`.
Liam Miller-Cu
On Thu, 21 Sep 2023 00:49:45 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Thu, 21 Sep 2023 00:49:45 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Thu, 21 Sep 2023 00:49:45 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
> Please consider this fix for
> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
> only handled `-Djava.net.preferIPv6Addresses=true` and
> `-Djava.net.preferIPv6Addresses=false`.
Liam Miller-Cu
On Wed, 20 Sep 2023 20:36:20 GMT, Chris Plummer wrote:
> It seems like the "IPv6-only system" part of the test should include more
> test cases, both passing and failing. I'm not sure why it was lmitted to just
> the one:
I have added additional test cases
> Does this test guarantee that "sys
On Wed, 20 Sep 2023 16:28:00 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Wed, 20 Sep 2023 00:18:59 GMT, Alex Menkov wrote:
> I took some time to understand what this code for. I think the condition is
> not correct. it should be
>
> ```
> if (!allowOnlyIPv4) {
> ```
>
> allowOnlyIPv4 (reflects "java.net.preferIPv4Stack" sys.prop) means that only
> IPv4 connecti
> Please consider this fix for
> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
> only handled `-Djava.net.preferIPv6Addresses=true` and
> `-Djava.net.preferIPv6Addresses=false`.
Liam Miller-Cu
On Tue, 19 Sep 2023 23:36:42 GMT, Chris Plummer wrote:
> The only time listenAddr is not set is when using AF_UNSPEC ("system").
@plummercj no it can also be unset if there are no listed addresses for the
preferred family e.g. you prefer v6 but they are all v4, or vice-versa. The new
code mak
On Tue, 19 Sep 2023 23:54:31 GMT, Liam Miller-Cushon wrote:
> > I think Alex has commented that this can be made more obvious with a check
> > for AF_UNSPEC.
>
> Thanks, yes, I have applied that suggestion.
>
> > > For 748, it's handling a situation where IPv4 isn't specifically
> > > preferr
On Tue, 19 Sep 2023 23:36:42 GMT, Chris Plummer wrote:
> I think Alex has commented that this can be made more obvious with a check
> for AF_UNSPEC.
Thanks, yes, I have applied that suggestion.
> > For 748, it's handling a situation where IPv4 isn't specifically preferred.
> > The implementat
On Tue, 19 Sep 2023 05:30:39 GMT, David Holmes wrote:
> Okay I see now that `ai` is not important. We won't have set `listenAddr` so
> we will take the first `addrInfo`. But this seems somewhat random behaviour
> as the first `addrInfo` could be either V4 or V6 (what controls the order?).
> Bu
> Please consider this fix for
> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
> only handled `-Djava.net.preferIPv6Addresses=true` and
> `-Djava.net.preferIPv6Addresses=false`.
Liam Miller-Cu
On Mon, 18 Sep 2023 23:57:33 GMT, Liam Miller-Cushon wrote:
> For 748, it's handling a situation where IPv4 isn't specifically preferred.
> The implementation comment notes 'if preferredAddressFamily is AF_INET6 or
> not set'.
What does "specifically preferred" mean? By default it will be set
On Tue, 19 Sep 2023 23:22:50 GMT, Alex Menkov wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix pre-existing typo
>
> 1st pass in attach (line 970) is also not needed, can be something like
>
> -/*
On Tue, 19 Sep 2023 15:41:23 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Tue, 19 Sep 2023 15:41:23 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Tue, 19 Sep 2023 21:40:18 GMT, Chris Plummer wrote:
> > Similar to @plummercj comment what about this code at L730:
> > ```
> > // Try to find bind address of preferred address family first.
> > for (ai = addrInfo; ai != NULL; ai = ai->ai_next) {
> > if (ai->ai_family == preferredA
On Mon, 18 Sep 2023 23:44:22 GMT, Chris Plummer wrote:
>> Liam Miller-Cushon has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one n
On Tue, 19 Sep 2023 11:03:36 GMT, Alan Bateman wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review feedback
>
> test/jdk/com/sun/jdi/JdwpNetProps.java line 75:
>
>> 73: .run(TestResult
> Please consider this fix for
> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
> only handled `-Djava.net.preferIPv6Addresses=true` and
> `-Djava.net.preferIPv6Addresses=false`.
Liam Miller-Cu
On Tue, 19 Sep 2023 00:03:27 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Tue, 19 Sep 2023 00:03:27 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Tue, 19 Sep 2023 00:03:27 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
On Mon, 18 Sep 2023 23:44:22 GMT, Chris Plummer wrote:
>> Liam Miller-Cushon has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one n
On Mon, 18 Sep 2023 23:44:22 GMT, Chris Plummer wrote:
>> Liam Miller-Cushon has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one n
On Mon, 18 Sep 2023 23:44:22 GMT, Chris Plummer wrote:
> Is the code starting at lines 748 and 970 still correct after your changes?
I think so, but scrutiny there is very welcome. I expected additional changes
to be necessary.
* For 748, it's handling a situation where IPv4 isn't specifically
> Please consider this fix for
> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
> only handled `-Djava.net.preferIPv6Addresses=true` and
> `-Djava.net.preferIPv6Addresses=false`.
Liam Miller-Cu
On Mon, 18 Sep 2023 20:47:22 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
>> only handled `-Djava.net.preferIPv6Addresses=tr
> Please consider this fix for
> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds
> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it
> only handled `-Djava.net.preferIPv6Addresses=true` and
> `-Djava.net.preferIPv6Addresses=false`.
Liam Miller-Cu
Please consider this fix for
[JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds support
to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it only handled
`-Djava.net.preferIPv6Addresses=true` and
`-Djava.net.preferIPv6Addresses=false`.
-
Commit me
35 matches
Mail list logo
