Re: RFR: JDK-8306441: Enhance parallel heap dump [v6]

2023-06-05 Thread Yi Yang
On Mon, 5 Jun 2023 23:44:04 GMT, Alex Menkov wrote: > A lot of code movement is caused by moving AbstractDumpWriter class from > heapDumper.cpp to heapDumpCompression.hpp/cpp > I'm not happy with huge heapDumper.cpp file, but this refactoring does not > look good to me. > Currently all logic ab

Re: RFR: JDK-8306441: Enhance parallel heap dump [v6]

2023-06-05 Thread Alex Menkov
On Wed, 17 May 2023 09:23:17 GMT, Yi Yang wrote: >> ### Motivation and proposal >> Hi, heap dump brings about pauses for application's execution(STW), this is >> a well-known pain. JDK-8252842 have added parallel support to heapdump in an >> attempt to alleviate this issue. However, all concurr

Re: RFR: JDK-8306441: Enhance parallel heap dump [v6]

2023-05-21 Thread Yi Yang
On Thu, 18 May 2023 11:02:21 GMT, Yi Yang wrote: > I'm interested in if it is faster in STW time with the parallel write to use > compression or not? (Does not compressing take time, or does compressing mean > we write fewer bytes, so ends up being faster.) I updated the benchmark data when tu

Re: RFR: JDK-8306441: Enhance parallel heap dump [v6]

2023-05-18 Thread Yi Yang
On Thu, 18 May 2023 09:35:36 GMT, Kevin Walls wrote: > I'm interested in if it is faster in STW time with the parallel write to use > compression or not? (Does not compressing take time, or does compressing mean > we write fewer bytes, so ends up being faster.) Hi @kevinjwalls, so far all benc