Re: RFR: JDK-8302455: VM.classloader_stats memory size values are wrong [v3]

2023-02-15 Thread Thomas Stuefe
On Wed, 15 Feb 2023 10:50:11 GMT, Thomas Stuefe wrote: >> VM.classloader_stats shows metaspace consumption in words, but should show >> bytes. >> >> Patch fixes that, and adjusts the associated jtreg test to catch regressions >> like this. >> >> I manually tested the test with the unpatched

Re: RFR: JDK-8302455: VM.classloader_stats memory size values are wrong [v3]

2023-02-15 Thread David Holmes
On Wed, 15 Feb 2023 10:50:11 GMT, Thomas Stuefe wrote: >> VM.classloader_stats shows metaspace consumption in words, but should show >> bytes. >> >> Patch fixes that, and adjusts the associated jtreg test to catch regressions >> like this. >> >> I manually tested the test with the unpatched

Re: RFR: JDK-8302455: VM.classloader_stats memory size values are wrong [v3]

2023-02-15 Thread Thomas Stuefe
> VM.classloader_stats shows metaspace consumption in words, but should show > bytes. > > Patch fixes that, and adjusts the associated jtreg test to catch regressions > like this. > > I manually tested the test with the unpatched hotspot to see if the > regression shows up, it does. > > Test

Re: RFR: JDK-8302455: VM.classloader_stats memory size values are wrong [v2]

2023-02-15 Thread Thomas Stuefe
> VM.classloader_stats shows metaspace consumption in words, but should show > bytes. > > Patch fixes that, and adjusts the associated jtreg test to catch regressions > like this. > > I manually tested the test with the unpatched hotspot to see if the > regression shows up, it does. > > Test

Re: RFR: JDK-8302455: VM.classloader_stats memory size values are wrong

2023-02-15 Thread Thomas Stuefe
On Wed, 15 Feb 2023 07:49:24 GMT, David Holmes wrote: > Given the reason this bug likely arose is the fact the parameters to > `calculate_jfr_stats` say they are "bytes" then fixing that is not a mere > cleanup IMO. Can we at least fix that in this PR? Hi David, I reformed the ill-named functi

Re: RFR: JDK-8302455: VM.classloader_stats memory size values are wrong

2023-02-14 Thread David Holmes
On Tue, 14 Feb 2023 13:40:40 GMT, Thomas Stuefe wrote: > VM.classloader_stats shows metaspace consumption in words, but should show > bytes. > > Patch fixes that, and adjusts the associated jtreg test to catch regressions > like this. > > I manually tested the test with the unpatched hotspot

Re: RFR: JDK-8302455: VM.classloader_stats memory size values are wrong

2023-02-14 Thread Thomas Stuefe
On Wed, 15 Feb 2023 05:49:14 GMT, David Holmes wrote: > That said, given: > > ``` > // This only exists for JFR and jcmd VM.classloader_stats. We may want to > // change this. Capacity as a stat is of questionable use since it may > // contain committed and uncommitted areas. For now we do thi

Re: RFR: JDK-8302455: VM.classloader_stats memory size values are wrong

2023-02-14 Thread David Holmes
On Tue, 14 Feb 2023 13:40:40 GMT, Thomas Stuefe wrote: > VM.classloader_stats shows metaspace consumption in words, but should show > bytes. > > Patch fixes that, and adjusts the associated jtreg test to catch regressions > like this. > > I manually tested the test with the unpatched hotspot

Re: RFR: JDK-8302455: VM.classloader_stats memory size values are wrong

2023-02-14 Thread Coleen Phillimore
On Tue, 14 Feb 2023 13:40:40 GMT, Thomas Stuefe wrote: > VM.classloader_stats shows metaspace consumption in words, but should show > bytes. > > Patch fixes that, and adjusts the associated jtreg test to catch regressions > like this. > > I manually tested the test with the unpatched hotspot

RFR: JDK-8302455: VM.classloader_stats memory size values are wrong

2023-02-14 Thread Thomas Stuefe
VM.classloader_stats shows metaspace consumption in words, but should show bytes. Patch fixes that, and adjusts the associated jtreg test to catch regressions like this. I manually tested the test with the unpatched hotspot to see if the regression shows up, it does. Tested the patch on x64