Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v4]

2022-11-15 Thread Joe Darcy
> Update the compile command in JdbLastErrorTest.java so that it doesn't need > to be modified with each new JDK release to keep using preview features. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v3]

2022-11-15 Thread Serguei Spitsyn
On Mon, 14 Nov 2022 20:39:47 GMT, Joe Darcy wrote: >> Update the compile command in JdbLastErrorTest.java so that it doesn't need >> to be modified with each new JDK release to keep using preview features. > > Joe Darcy has updated the pull request incrementally with one additional > commit sin

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v3]

2022-11-14 Thread Alan Bateman
On Mon, 14 Nov 2022 20:39:47 GMT, Joe Darcy wrote: >> Update the compile command in JdbLastErrorTest.java so that it doesn't need >> to be modified with each new JDK release to keep using preview features. > > Joe Darcy has updated the pull request incrementally with one additional > commit sin

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v3]

2022-11-14 Thread Kevin Walls
On Mon, 14 Nov 2022 20:39:47 GMT, Joe Darcy wrote: >> Update the compile command in JdbLastErrorTest.java so that it doesn't need >> to be modified with each new JDK release to keep using preview features. > > Joe Darcy has updated the pull request incrementally with one additional > commit sin

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v3]

2022-11-14 Thread Chris Plummer
On Mon, 14 Nov 2022 20:39:47 GMT, Joe Darcy wrote: >> Update the compile command in JdbLastErrorTest.java so that it doesn't need >> to be modified with each new JDK release to keep using preview features. > > Joe Darcy has updated the pull request incrementally with one additional > commit sin

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v3]

2022-11-14 Thread Joe Darcy
> Update the compile command in JdbLastErrorTest.java so that it doesn't need > to be modified with each new JDK release to keep using preview features. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update. - Changes:

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v2]

2022-11-14 Thread Joe Darcy
On Mon, 14 Nov 2022 19:13:22 GMT, Alan Bateman wrote: >> Is that a new jtreg feature? I've used the idiom in the updated version of >> this file elsewhere in the JDK. > > https://bugs.openjdk.org/browse/CODETOOLS-7902654 > I only became aware of it a few months ago. Thanks @AlanBateman; I wasn'

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v2]

2022-11-14 Thread Joe Darcy
> Update the compile command in JdbLastErrorTest.java so that it doesn't need > to be modified with each new JDK release to keep using preview features. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. --

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java

2022-11-14 Thread Alan Bateman
On Mon, 14 Nov 2022 19:09:10 GMT, Joe Darcy wrote: >> test/jdk/com/sun/jdi/JdbLastErrorTest.java line 31: >> >>> 29: * @library /test/lib >>> 30: * @run compile --release ${jdk.version} --enable-preview >>> JdbLastErrorTest.java >>> 31: * @run main/othervm --enable-preview JdbLastErrorTest >

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java

2022-11-14 Thread Joe Darcy
On Mon, 14 Nov 2022 19:07:42 GMT, Alan Bateman wrote: >> Update the compile command in JdbLastErrorTest.java so that it doesn't need >> to be modified with each new JDK release to keep using preview features. > > test/jdk/com/sun/jdi/JdbLastErrorTest.java line 31: > >> 29: * @library /test/lib

Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java

2022-11-14 Thread Alan Bateman
On Mon, 14 Nov 2022 18:49:14 GMT, Joe Darcy wrote: > Update the compile command in JdbLastErrorTest.java so that it doesn't need > to be modified with each new JDK release to keep using preview features. test/jdk/com/sun/jdi/JdbLastErrorTest.java line 31: > 29: * @library /test/lib > 30: * @

RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java

2022-11-14 Thread Joe Darcy
Update the compile command in JdbLastErrorTest.java so that it doesn't need to be modified with each new JDK release to keep using preview features. - Commit messages: - JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java Changes: https://git.openjdk.org/jdk/pull/111