Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v3]

2022-09-21 Thread Thomas Stuefe
On Wed, 21 Sep 2022 16:32:30 GMT, Chris Plummer wrote: >> Thomas Stuefe has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix test error in GHAs >> - feedback dholmes >> - childs->children > > Marked as reviewed by cjplummer (Reviewe

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v3]

2022-09-21 Thread Chris Plummer
On Wed, 21 Sep 2022 06:51:56 GMT, Thomas Stuefe wrote: >> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be >> omitted from the output if a parent class loader never loaded any class and >> therefore had no associated DCmd. >> >> The fix changes the command to not rely

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v3]

2022-09-21 Thread David Holmes
On Wed, 21 Sep 2022 06:51:56 GMT, Thomas Stuefe wrote: >> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be >> omitted from the output if a parent class loader never loaded any class and >> therefore had no associated DCmd. >> >> The fix changes the command to not rely

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v2]

2022-09-20 Thread Thomas Stuefe
On Tue, 20 Sep 2022 05:37:44 GMT, Thomas Stuefe wrote: >> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be >> omitted from the output if a parent class loader never loaded any class and >> therefore had no associated DCmd. >> >> The fix changes the command to not rely

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy

2022-09-20 Thread Thomas Stuefe
On Tue, 20 Sep 2022 05:33:10 GMT, Thomas Stuefe wrote: > Hi @plummercj , thanks for your Review. I worked most of your your feedback. > > .. Thomas - PR: https://git.openjdk.org/jdk/pull/10312

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v3]

2022-09-20 Thread Thomas Stuefe
> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be > omitted from the output if a parent class loader never loaded any class and > therefore had no associated DCmd. > > The fix changes the command to not rely on the existence of a CLD structure > for the loader; instead

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v2]

2022-09-20 Thread Thomas Stuefe
On Wed, 21 Sep 2022 02:26:02 GMT, David Holmes wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cjplummer feedback > > src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp line 209: > >> 207: st->print

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v2]

2022-09-20 Thread David Holmes
On Tue, 20 Sep 2022 05:37:44 GMT, Thomas Stuefe wrote: >> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be >> omitted from the output if a parent class loader never loaded any class and >> therefore had no associated DCmd. >> >> The fix changes the command to not rely

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v2]

2022-09-20 Thread Chris Plummer
On Tue, 20 Sep 2022 05:29:12 GMT, Thomas Stuefe wrote: >> src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp line 187: >> >>> 185: } >>> 186: >>> 187: void print_with_childs(outputStream* st, BranchTracker& >>> branchtracker, >> >> I know this isn't part of your changes, but the plu

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v2]

2022-09-19 Thread Thomas Stuefe
On Mon, 19 Sep 2022 18:45:35 GMT, Chris Plummer wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cjplummer feedback > > src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp line 187: > >> 185: } >> 186: >>

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v2]

2022-09-19 Thread Thomas Stuefe
> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be > omitted from the output if a parent class loader never loaded any class and > therefore had no associated DCmd. > > The fix changes the command to not rely on the existence of a CLD structure > for the loader; instead

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy

2022-09-19 Thread Thomas Stuefe
On Fri, 16 Sep 2022 14:55:42 GMT, Thomas Stuefe wrote: > Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be > omitted from the output if a parent class loader never loaded any class and > therefore had no associated DCmd. > > The fix changes the command to not rely on th

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy

2022-09-19 Thread Chris Plummer
On Fri, 16 Sep 2022 14:55:42 GMT, Thomas Stuefe wrote: > Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be > omitted from the output if a parent class loader never loaded any class and > therefore had no associated DCmd. > > The fix changes the command to not rely on th

RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy

2022-09-16 Thread Thomas Stuefe
Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be omitted from the output if a parent class loader never loaded any class and therefore had no associated DCmd. The fix changes the command to not rely on the existence of a CLD structure for the loader; instead, all inform