Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v6]

2025-06-26 Thread duke
On Wed, 25 Jun 2025 11:26:22 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v6]

2025-06-25 Thread Alan Bateman
On Wed, 25 Jun 2025 11:26:22 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v5]

2025-06-25 Thread Alan Bateman
On Wed, 25 Jun 2025 11:35:51 GMT, Anton Artemov wrote: >> test/jdk/jdk/internal/vm/Continuation/Fuzz.java line 477: >> >>> 475: boolean shouldPin() { >>> 476: // Returns false since we never pin after we removed legacy >>> locking. >>> 477: return traceHas(Op.PIN::contains)

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-25 Thread David Holmes
On Mon, 23 Jun 2025 10:39:59 GMT, Anton Artemov wrote: >> test/hotspot/jtreg/runtime/Monitor/StressWrapper_TestRecursiveLocking_36M.java >> line 36: >> >>> 34: * -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI >>> 35: * -Xint >>> 36: * -XX:LockingMode=0 >> >> I was wondering why

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v3]

2025-06-25 Thread Anton Artemov
On Tue, 24 Jun 2025 10:05:36 GMT, David Holmes wrote: >> Anton Artemov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8359437: Addressed reviewer's comments. > > test/hotspot/jtreg/runtime/Monitor/ConcurrentDeflation.java line 79: > >>

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v2]

2025-06-25 Thread Anton Artemov
On Tue, 24 Jun 2025 03:09:06 GMT, David Holmes wrote: >> Anton Artemov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8359437: Addressed reviewers' comments >> - 8359437: Addressed reviewers' comments > > test/jtreg-ext/requires/VMPr

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v6]

2025-06-25 Thread Fredrik Bredberg
On Wed, 25 Jun 2025 11:26:22 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v6]

2025-06-25 Thread Leonid Mesnik
On Wed, 25 Jun 2025 11:26:22 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v2]

2025-06-25 Thread Anton Artemov
On Mon, 23 Jun 2025 17:04:37 GMT, Leonid Mesnik wrote: >> Anton Artemov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8359437: Addressed reviewers' comments >> - 8359437: Addressed reviewers' comments > > test/hotspot/jtreg/gtest/Lo

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v5]

2025-06-25 Thread Anton Artemov
On Wed, 25 Jun 2025 11:13:32 GMT, Alan Bateman wrote: >> Anton Artemov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8359437: Addressed reviewer's comment > > test/jdk/jdk/internal/vm/Continuation/Fuzz.java line 477: > >> 475: boo

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v6]

2025-06-25 Thread Coleen Phillimore
On Wed, 25 Jun 2025 11:26:22 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v6]

2025-06-25 Thread Anton Artemov
> This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode` variable in all places, but > makes it non-settable from

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v5]

2025-06-25 Thread Alan Bateman
On Tue, 24 Jun 2025 13:25:20 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v5]

2025-06-25 Thread Coleen Phillimore
On Tue, 24 Jun 2025 09:12:00 GMT, Anton Artemov wrote: >> test/jtreg-ext/requires/VMProps.java line 424: >> >>> 422: * Note: Lightweight locking does not support RTM (for now). >>> 423: */ >>> 424: protected String vmRTMCompiler() { >> >> [JDK-8358542](https://bugs.openjdk.org/bro

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v5]

2025-06-24 Thread David Holmes
On Tue, 24 Jun 2025 13:25:20 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v4]

2025-06-24 Thread Anton Artemov
On Tue, 24 Jun 2025 12:43:36 GMT, Alan Bateman wrote: >> Anton Artemov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8359437: Addressed reviewer's comments > > test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTe

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v5]

2025-06-24 Thread Anton Artemov
On Tue, 24 Jun 2025 12:44:52 GMT, Alan Bateman wrote: >> Anton Artemov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8359437: Addressed reviewer's comment > > test/jdk/jdk/internal/vm/Continuation/Basic.java line 426: > >> 424:

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v5]

2025-06-24 Thread Anton Artemov
> This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode` variable in all places, but > makes it non-settable from

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v4]

2025-06-24 Thread Alan Bateman
On Tue, 24 Jun 2025 11:16:21 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v4]

2025-06-24 Thread Anton Artemov
> This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode` variable in all places, but > makes it non-settable from

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v4]

2025-06-24 Thread David Holmes
On Tue, 24 Jun 2025 11:16:21 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v2]

2025-06-24 Thread David Holmes
On Tue, 24 Jun 2025 09:14:42 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-24 Thread David Holmes
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote: > This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode`

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v2]

2025-06-24 Thread Anton Artemov
On Tue, 24 Jun 2025 09:14:37 GMT, David Holmes wrote: >> Anton Artemov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8359437: Addressed reviewers' comments >> - 8359437: Addressed reviewers' comments > > test/hotspot/jtreg/runtime/M

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v3]

2025-06-24 Thread David Holmes
On Tue, 24 Jun 2025 09:59:50 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v3]

2025-06-24 Thread Anton Artemov
> This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode` variable in all places, but > makes it non-settable from

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v2]

2025-06-24 Thread Anton Artemov
On Mon, 23 Jun 2025 15:48:41 GMT, Alan Bateman wrote: >> Anton Artemov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8359437: Addressed reviewers' comments >> - 8359437: Addressed reviewers' comments > > test/jdk/java/lang/Thread/vi

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v2]

2025-06-24 Thread Anton Artemov
> This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode` variable in all places, but > makes it non-settable from

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-23 Thread David Holmes
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote: > This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode`

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-23 Thread Leonid Mesnik
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote: > This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode`

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-23 Thread Alan Bateman
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote: > This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode`

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-23 Thread Coleen Phillimore
On Wed, 18 Jun 2025 07:52:02 GMT, David Holmes wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Locking

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-23 Thread Anton Artemov
On Wed, 18 Jun 2025 18:23:58 GMT, Coleen Phillimore wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lo

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-23 Thread Anton Artemov
On Wed, 18 Jun 2025 07:37:31 GMT, David Holmes wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Locking

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-23 Thread Coleen Phillimore
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote: > This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode`

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-23 Thread David Holmes
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote: > This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode`

RFR: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-23 Thread Anton Artemov
This PR contains changes for the 1st phase of the `LockingMode` flag obsoletion. The work is done by @fbredber, I have taken it over and am finishing it while he's on vacation. In the 1st phase one keeps the `LockingMode` variable in all places, but makes it non-settable from the command lin