Re: RFR: 8352392: AIX: implement attach API v2 and streaming output [v3]

2025-04-01 Thread Varada M
On Mon, 31 Mar 2025 10:16:31 GMT, Martin Doerr wrote: >> Varada M has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - updated copyright header >> - removed StreamingOutputTest.java from problem list > > src/jdk.attach/aix/classes/sun/tool

Re: RFR: 8352392: AIX: implement attach API v2 and streaming output [v3]

2025-04-01 Thread Martin Doerr
On Tue, 1 Apr 2025 10:32:55 GMT, Varada M wrote: >> src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java line 196: >> >>> 194: } >>> 195: } >>> 196: >> >> Same here. > > Hi Martin, I have added the indentation fix and comment Thanks! I think it's good. Let's wait

Re: RFR: 8352392: AIX: implement attach API v2 and streaming output [v3]

2025-03-31 Thread Martin Doerr
On Fri, 28 Mar 2025 09:01:26 GMT, Varada M wrote: >> AIX changes for attach API to support arbitrary length arguments and the >> streaming output support. >> serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes >> >> tier1, tier2 and tier3 testing is successful with fastdebug

Re: RFR: 8352392: AIX: implement attach API v2 and streaming output [v3]

2025-03-28 Thread Alex Menkov
On Fri, 28 Mar 2025 09:01:26 GMT, Varada M wrote: >> AIX changes for attach API to support arbitrary length arguments and the >> streaming output support. >> serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes >> >> tier1, tier2 and tier3 testing is successful with fastdebug

Re: RFR: 8352392: AIX: implement attach API v2 and streaming output [v3]

2025-03-28 Thread Varada M
> AIX changes for attach API to support arbitrary length arguments and the > streaming output support. > serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes > > tier1, tier2 and tier3 testing is successful with fastdebug level > > JBS Issue : [JDK-8352392](https://bugs.openjd