Re: RFR: 8346773: Fix unmatched brackets in source files [v3]

2024-12-25 Thread Alan Bateman
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote: >> This patch fixes unmatched brackets in some source files. > > Qizheng Xing has updated the pull request incrementally with one additional > commit since the last revision: > > Revert fix in the CTW Makefile. The title on the JBS issue

Re: RFR: 8346773: Fix unmatched brackets in source files [v3]

2024-12-24 Thread Kim Barrett
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote: >> This patch fixes unmatched brackets in some source files. > > Qizheng Xing has updated the pull request incrementally with one additional > commit since the last revision: > > Revert fix in the CTW Makefile. Looks good. -

Re: RFR: 8346773: Fix unmatched brackets in source files [v3]

2024-12-24 Thread Qizheng Xing
On Mon, 23 Dec 2024 19:42:34 GMT, Kim Barrett wrote: >> I strongly suggest avoiding omnibus changes like this when possible (which it >> is here). Just because it's all about one "kind" of change doesn't make it a >> cohesive change. This is touching many distinct areas of the JDK, and several >>

Re: RFR: 8346773: Fix unmatched brackets in source files [v3]

2024-12-24 Thread Qizheng Xing
> This patch fixes unmatched brackets in some source files. Qizheng Xing has updated the pull request incrementally with one additional commit since the last revision: Revert fix in the CTW Makefile. - Changes: - all: https://git.openjdk.org/jdk/pull/22861/files - new: https: