On Mon, 16 Dec 2024 20:33:22 GMT, Coleen Phillimore wrote:
> Please review this trivial change to remove unused SA code. Ran
> serviceability/sa tests, tier1 testing in progress.
Thanks Chris and Serguei.
-
PR Comment: https://git.openjdk.org/jdk/pull/22772#issuecomment-254834630
On Mon, 16 Dec 2024 20:33:22 GMT, Coleen Phillimore wrote:
> Please review this trivial change to remove unused SA code. Ran
> serviceability/sa tests, tier1 testing in progress.
Looks good.
-
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pul
On Mon, 16 Dec 2024 22:41:23 GMT, Coleen Phillimore wrote:
> Do you agree it's trivial?
I'm not sure about it.
-
PR Comment: https://git.openjdk.org/jdk/pull/22772#issuecomment-2547114241
On Mon, 16 Dec 2024 20:33:22 GMT, Coleen Phillimore wrote:
> Please review this trivial change to remove unused SA code. Ran
> serviceability/sa tests, tier1 testing in progress.
ok, I'll wait and see what @plummercj says.
-
PR Comment: https://git.openjdk.org/jdk/pull/22772#issu
On Mon, 16 Dec 2024 20:33:22 GMT, Coleen Phillimore wrote:
> Please review this trivial change to remove unused SA code. Ran
> serviceability/sa tests, tier1 testing in progress.
Do you agree it's trivial? GHA almost complete/passed.
-
PR Comment: https://git.openjdk.org/jdk/pul
On Mon, 16 Dec 2024 20:33:22 GMT, Coleen Phillimore wrote:
> Please review this trivial change to remove unused SA code. Ran
> serviceability/sa tests, tier1 testing in progress.
Looks okay to me.
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jd
Please review this trivial change to remove unused SA code. Ran
serviceability/sa tests, tier1 testing in progress.
-
Commit messages:
- 8346304: SA doesn't need a copy of getModifierFlags.
Changes: https://git.openjdk.org/jdk/pull/22772/files
Webrev: https://webrevs.openjdk.org