On Thu, 19 Dec 2024 02:19:29 GMT, David Holmes wrote:
> Okay ... still not sure this shouldn't be dynamically determining whether
> stdout or stderr is the right target.
We should really have a not-blocking variant of `tty` since er use tty for
things like debug output when being deep down the
On Thu, 19 Dec 2024 02:19:29 GMT, David Holmes wrote:
>> This change was decided on in the original PR after it was discovered that
>> calling
>> [os::print_memory_mappings](https://github.com/openjdk/jdk/blob/jdk-25%2B2/src/hotspot/os/windows/os_windows.cpp#L3623)
>> from the windows implemen
On Wed, 18 Dec 2024 19:58:58 GMT, Kim Barrett wrote:
> You don't change ConditionalMutexLocker at all. Just change how it's used:
Doh! @kimbarrett don't know what I was thinking. Thanks
-
PR Comment: https://git.openjdk.org/jdk/pull/22745#issuecomment-2552637884
On Wed, 18 Dec 2024 14:36:41 GMT, Robert Toyonaga wrote:
>> src/hotspot/os/windows/os_windows.cpp line 3624:
>>
>>> 3622: #ifdef ASSERT
>>> 3623: fileStream fs(stdout);
>>> 3624: os::print_memory_mappings((char*)start, bytes, &fs);
>>
>> Why was this change made? tty could be stdout
On Wed, 18 Dec 2024 04:37:22 GMT, David Holmes wrote:
> The direct use of CML is functionally correct but requires leaking knowledge
> to all the use-sites that should not need to know about the actual condition
> for locking. This really needs to be encapsulated which means we need to be
> ab
On Wed, 18 Dec 2024 04:31:45 GMT, David Holmes wrote:
>> Robert Toyonaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates tests and remove old class
>
> src/hotspot/share/runtime/threads.cpp line 530:
>
>> 528:
>> 529: // Once
On Wed, 18 Dec 2024 04:24:51 GMT, David Holmes wrote:
>> Robert Toyonaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates tests and remove old class
>
> src/hotspot/os/windows/os_windows.cpp line 3624:
>
>> 3622: #ifdef ASSERT
>>
On Tue, 17 Dec 2024 15:46:01 GMT, Robert Toyonaga wrote:
>> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
>> which was backed out by
>> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
>> documented in [JDK-8343244](https://bugs.openjdk.
On Tue, 17 Dec 2024 15:46:01 GMT, Robert Toyonaga wrote:
>> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
>> which was backed out by
>> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
>> documented in [JDK-8343244](https://bugs.openjdk.
> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
> which was backed out by
> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
> documented in [JDK-8343244](https://bugs.openjdk.org/browse/JDK-8343244).
>
> The problem was that `NmtVirtualM
10 matches
Mail list logo
