Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Alan Bateman
On Thu, 5 Dec 2024 15:16:46 GMT, Chen Liang wrote: >> I had hoped to keep the change focused on the removal of the left over >> ReflectUtil.checkPackageAccess, the else throw AssertionError was a surprise >> to see. So yes, I agree it can be removed but I'd prefer not touch it now, >> future w

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Alan Bateman
On Thu, 5 Dec 2024 14:50:53 GMT, Chen Liang wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright header end dates > > src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 15:01:27 GMT, Alan Bateman wrote: >> src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java >> line 138: >> >>> 136: assert genericDeclaration instanceof Class || >>> 137: genericDeclaration instanceof Method || >>> 13

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 14:46:14 GMT, Alan Bateman wrote: >> We hollowed out ReflectUtil as one of the early steps when removing the code >> for running in the SecurityManager execution mode. Most of the usages have >> now been removed so the empty (and unused) methods can be removed. >> FieldUtils

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Sean Mullan
On Thu, 5 Dec 2024 14:46:14 GMT, Alan Bateman wrote: >> We hollowed out ReflectUtil as one of the early steps when removing the code >> for running in the SecurityManager execution mode. Most of the usages have >> now been removed so the empty (and unused) methods can be removed. >> FieldUtils

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Roger Riggs
On Thu, 5 Dec 2024 14:46:14 GMT, Alan Bateman wrote: >> We hollowed out ReflectUtil as one of the early steps when removing the code >> for running in the SecurityManager execution mode. Most of the usages have >> now been removed so the empty (and unused) methods can be removed. >> FieldUtils

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Alan Bateman
> We hollowed out ReflectUtil as one of the early steps when removing the code > for running in the SecurityManager execution mode. Most of the usages have > now been removed so the empty (and unused) methods can be removed. FieldUtils > and ConstructorUtils can be removed too. > > ObjectInputS

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util

2024-12-05 Thread Sean Mullan
On Thu, 5 Dec 2024 10:20:50 GMT, Alan Bateman wrote: > We hollowed out ReflectUtil as one of the early steps when removing the code > for running in the SecurityManager execution mode. Most of the usages have > now been removed so the empty (and unused) methods can be removed. FieldUtils > and

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util

2024-12-05 Thread Kevin Walls
On Thu, 5 Dec 2024 10:20:50 GMT, Alan Bateman wrote: > We hollowed out ReflectUtil as one of the early steps when removing the code > for running in the SecurityManager execution mode. Most of the usages have > now been removed so the empty (and unused) methods can be removed. FieldUtils > and

RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util

2024-12-05 Thread Alan Bateman
We hollowed out ReflectUtil as one of the early steps when removing the code for running in the SecurityManager execution mode. Most of the usages have now been removed so the empty (and unused) methods can be removed. FieldUtils and ConstructorUtils can be removed too. ObjectInputStream/Object