Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-03 Thread Daniel Fuchs
On Tue, 3 Dec 2024 06:14:31 GMT, Jaikiran Pai wrote: >> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java >> line 68: >> >>> 66: try (Stream lines = Files.lines(filePath)) { >>> 67: Optional firstLine = lines.findFirst(); >>> 68: re

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 18:54:33 GMT, Alan Bateman wrote: >> src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 31: >> >>> 29: >>> 30: /** >>> 31: * A thread that has no permissions, is not a member of any user-defined >> >> I think you can also remove the words "has no permis

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 17:47:57 GMT, Daniel Fuchs wrote: >> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 13 commits: >> >> - merge latest from master branch >> - remove changes to >> src/java.base/unix/classes/sun/s

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Severin Gehwolf
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Jaikiran Pai
> Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > changes are trivial. The > `src/java.base/linux/classes/jdk/

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Alan Bateman
On Mon, 2 Dec 2024 18:48:27 GMT, Sean Mullan wrote: >> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 13 commits: >> >> - merge latest from master branch >> - remove changes to >> src/java.base/unix/classes/sun/se

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Sean Mullan
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Daniel Fuchs
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>