Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Alan Bateman
On Tue, 12 Nov 2024 12:10:07 GMT, Alan Bateman wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> rename address to offset, from @AlanBateman > > Marked as reviewed by alanb (Reviewer). > @AlanBateman @minborg Sorry,

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 12:10:07 GMT, Alan Bateman wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> rename address to offset, from @AlanBateman > > Marked as reviewed by alanb (Reviewer). @AlanBateman @minborg Sorry, a

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 12:18:03 GMT, Per Minborg wrote: > I want to add such a test case, but I am worried that it will consume too > many resources during the build process. > > ```java > /** > * @test > * @bug 8343984 > * @summary Test that the append capacity is close to Integer.MaxValue >

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Per Minborg
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Alan Bateman
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Per Minborg
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
> In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: rename address to of