Re: RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id [v2]

2024-12-04 Thread Patricio Chilano Mateo
On Wed, 4 Dec 2024 15:47:26 GMT, Patricio Chilano Mateo wrote: >> Please review this small renaming patch. During the review of JDK-8338383 >> there were some comments about improving the naming for >> `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate >> from the chang

Re: RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id [v2]

2024-12-04 Thread Coleen Phillimore
On Wed, 4 Dec 2024 15:47:26 GMT, Patricio Chilano Mateo wrote: >> Please review this small renaming patch. During the review of JDK-8338383 >> there were some comments about improving the naming for >> `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate >> from the chang

Re: RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id [v2]

2024-12-04 Thread Patricio Chilano Mateo
On Wed, 4 Dec 2024 01:36:42 GMT, David Holmes wrote: >> Patricio Chilano Mateo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix parameter name > > src/hotspot/share/runtime/javaThread.hpp line 174: > >> 172: void set_monitor_owner_

Re: RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id [v2]

2024-12-04 Thread Patricio Chilano Mateo
> Please review this small renaming patch. During the review of JDK-8338383 > there were some comments about improving the naming for > `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate > from the changes introduced to inflated monitors, where we now record the > `java.l

Re: RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id

2024-12-03 Thread David Holmes
On Tue, 3 Dec 2024 19:10:55 GMT, Patricio Chilano Mateo wrote: > Please review this small renaming patch. During the review of JDK-8338383 > there were some comments about improving the naming for > `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate > from the changes i

Re: RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id

2024-12-03 Thread Coleen Phillimore
On Tue, 3 Dec 2024 19:10:55 GMT, Patricio Chilano Mateo wrote: > Please review this small renaming patch. During the review of JDK-8338383 > there were some comments about improving the naming for > `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate > from the changes i

RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id

2024-12-03 Thread Patricio Chilano Mateo
Please review this small renaming patch. During the review of JDK-8338383 there were some comments about improving the naming for `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate from the changes introduced to inflated monitors, where we now record the `java.lang.Thread.