Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v2]

2024-11-27 Thread David Holmes
On Thu, 28 Nov 2024 01:54:10 GMT, Kim Barrett wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update src/java.base/share/native/libjava/NativeLibraries.c >> >> Co-authored-by: Alex Menkov <69548902+alexmen...@

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v2]

2024-11-27 Thread Kim Barrett
On Wed, 27 Nov 2024 05:20:16 GMT, David Holmes wrote: >> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) >> was integrated, the handling of certain symbol lookup code can be >> simplified. The old code needed to support 32-bit Windows, where names had a >> trailing `@

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v2]

2024-11-27 Thread Alex Menkov
On Wed, 27 Nov 2024 05:20:16 GMT, David Holmes wrote: >> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) >> was integrated, the handling of certain symbol lookup code can be >> simplified. The old code needed to support 32-bit Windows, where names had a >> trailing `@

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v2]

2024-11-26 Thread David Holmes
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was > integrated, the handling of certain symbol lookup code can be simplified. The > old code needed to support 32-bit Windows, where names had a trailing > `@`. When this special case now is removed, some streamlining

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v2]

2024-11-26 Thread David Holmes
On Wed, 27 Nov 2024 01:43:34 GMT, Alex Menkov wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update src/java.base/share/native/libjava/NativeLibraries.c >> >> Co-authored-by: Alex Menkov <69548902+alexmen...@