Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-16 Thread Coleen Phillimore
On Sat, 16 Nov 2024 03:22:01 GMT, John R Rose wrote: >> src/hotspot/share/prims/jvm.cpp line 169: >> >>> 167: while (!vfst.at_end()) { >>> 168: Method* m = vfst.method(); >>> 169: if >>> (!vfst.method()->method_holder()->is_subclass_of(vmClasses::ClassLoader_klass())) >>> { >>

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-16 Thread Coleen Phillimore
On Sat, 16 Nov 2024 02:41:59 GMT, John R Rose wrote: >> Coleen Phillimore has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains nine commits: >> >> - Handle merge conflicts in new resolve_instance_class calls. >> - Merge branch 'maste

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread Coleen Phillimore
> Remove Hotspot code that passes protection_domain around class loading so > that checkPackageAccess can be called and the result stored. With the > removal of the Security Manager in JEP 486, this code no longer does anything. > > Tested with tier1-4. Coleen Phillimore has updated the pull r

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread John R Rose
On Fri, 15 Nov 2024 23:43:33 GMT, Coleen Phillimore wrote: >> Remove Hotspot code that passes protection_domain around class loading so >> that checkPackageAccess can be called and the result stored. With the >> removal of the Security Manager in JEP 486, this code no longer does >> anything.

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread John R Rose
On Sat, 16 Nov 2024 02:48:09 GMT, John R Rose wrote: >> Coleen Phillimore has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains nine commits: >> >> - Handle merge conflicts in new resolve_instance_class calls. >> - Merge branch 'maste

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread John R Rose
On Fri, 15 Nov 2024 23:43:33 GMT, Coleen Phillimore wrote: >> Remove Hotspot code that passes protection_domain around class loading so >> that checkPackageAccess can be called and the result stored. With the >> removal of the Security Manager in JEP 486, this code no longer does >> anything.

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread Ioi Lam
On Fri, 15 Nov 2024 23:43:33 GMT, Coleen Phillimore wrote: >> Remove Hotspot code that passes protection_domain around class loading so >> that checkPackageAccess can be called and the result stored. With the >> removal of the Security Manager in JEP 486, this code no longer does >> anything.