Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-10 Thread Kim Barrett
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > Matthias Baesken has

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-10 Thread Matthias Baesken
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > Matthias Baesken has

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-09 Thread Lutz Schmidt
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > Matthias Baesken has

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-09 Thread Chris Plummer
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > Matthias Baesken has

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-09 Thread Chris Plummer
On Wed, 9 Oct 2024 10:36:28 GMT, Matthias Baesken wrote: >> Might be a good idea to have rslt commented out rather than removed outright >> if we don't want to forget about it. guarantee on a variable that doesn't >> exist will be rather confusing to anyone reading through the code > >> Might b

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-09 Thread Matthias Baesken
On Tue, 8 Oct 2024 13:38:54 GMT, Matthias Baesken wrote: > There are a few warnings as errors occurring when building on Linux with > clang (clang15). Mostly these are some kind of 'unused' warnings. > Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . I brought back `rslt` but

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-09 Thread Matthias Baesken
> There are a few warnings as errors occurring when building on Linux with > clang (clang15). Mostly these are some kind of 'unused' warnings. > Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . Matthias Baesken has updated the pull request incrementally with one additional commi

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-09 Thread Matthias Baesken
On Wed, 9 Oct 2024 07:26:41 GMT, Julian Waters wrote: > Might be a good idea to have rslt commented out Why not; Chris what do you say ? - PR Review Comment: https://git.openjdk.org/jdk/pull/21407#discussion_r1793282296

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-09 Thread Julian Waters
On Wed, 9 Oct 2024 06:25:07 GMT, Matthias Baesken wrote: >> src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c line 393: >> >>> 391: >>> 392: hcreate_r(htab_sz, symtab->hash_table); >>> 393: // guarantee(rslt, "unexpected failure: hcreate_r"); >> >> The commented out guarantee l

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-08 Thread Matthias Baesken
On Tue, 8 Oct 2024 16:30:36 GMT, Chris Plummer wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > src/jdk.hotspot.agent/li

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-08 Thread Chris Plummer
On Tue, 8 Oct 2024 13:38:54 GMT, Matthias Baesken wrote: > There are a few warnings as errors occurring when building on Linux with > clang (clang15). Mostly these are some kind of 'unused' warnings. > Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . src/jdk.hotspot.agent/linux

RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-08 Thread Matthias Baesken
There are a few warnings as errors occurring when building on Linux with clang (clang15). Mostly these are some kind of 'unused' warnings. Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . - Commit messages: - JDK-8341722 Changes: https://git.openjdk.org/jdk/pull/21