Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v11]

2024-10-28 Thread Serguei Spitsyn
On Sat, 26 Oct 2024 06:40:00 GMT, Serguei Spitsyn wrote: >> Good catch, thanks. >> These two functions are impacted by temporary VTMS transitions. It seems we >> fail to hide frames in these transitions while we skip the JVMTI events in >> their context. I'll try to fix this issue. > > I'd sugg

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v11]

2024-10-26 Thread Serguei Spitsyn
On Thu, 24 Oct 2024 22:58:01 GMT, Alex Menkov wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: removed asserts from continuationFreezeThaw.cpp again > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 667:

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v11]

2024-10-26 Thread Serguei Spitsyn
On Sat, 26 Oct 2024 06:34:08 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnvBase.cpp line 667: >> >>> 665: >>> 666: javaVFrame* >>> 667: JvmtiEnvBase::check_and_skip_hidden_frames(bool is_in_VTMS_transition, >>> javaVFrame* jvf) { >> >> reworked function looks much better! Now

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v11]

2024-10-24 Thread Serguei Spitsyn
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition > frames hiding mechanism. > Please, see a fix description in the first comment. > > Testing: > - Verified with new test `vthread/CheckHiddenFrames` > - Mach5 tiers 1-6 are passed Serguei Spitsyn has updated the pull re

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v11]

2024-10-24 Thread Alex Menkov
On Thu, 24 Oct 2024 14:52:27 GMT, Serguei Spitsyn wrote: >> This fixes a problem in the VTMS (Virtual Thread Mount State) transition >> frames hiding mechanism. >> Please, see a fix description in the first comment. >> >> Testing: >> - Verified with new test `vthread/CheckHiddenFrames` >> - M