Re: RFR: 8340213: jcmd VM.events ignores max argument [v2]

2024-09-17 Thread Leonid Mesnik
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote: >> The inner 'int max;' declaration hide previous max. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - typo fixed. > - check added. I filed separate https://bugs

Re: RFR: 8340213: jcmd VM.events ignores max argument [v2]

2024-09-17 Thread Kevin Walls
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote: >> The inner 'int max;' declaration hide previous max. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - typo fixed. > - check added. If this is not too late: it's

Re: RFR: 8340213: jcmd VM.events ignores max argument [v2]

2024-09-17 Thread Hamlin Li
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote: >> The inner 'int max;' declaration hide previous max. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - typo fixed. > - check added. Marked as reviewed by mli (Rev

Re: RFR: 8340213: jcmd VM.events ignores max argument [v2]

2024-09-16 Thread Alex Menkov
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote: >> The inner 'int max;' declaration hide previous max. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - typo fixed. > - check added. Marked as reviewed by amenkov

Re: RFR: 8340213: jcmd VM.events ignores max argument [v2]

2024-09-16 Thread Chris Plummer
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote: >> The inner 'int max;' declaration hide previous max. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - typo fixed. > - check added. Looks good. Thanks for adding

Re: RFR: 8340213: jcmd VM.events ignores max argument [v2]

2024-09-16 Thread Leonid Mesnik
On Mon, 16 Sep 2024 19:34:40 GMT, Sonia Zaldana Calles wrote: >> Leonid Mesnik has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - typo fixed. >> - check added. > > test/hotspot/jtreg/serviceability/dcmd/vm/EventsTest.java line 81: > >>

Re: RFR: 8340213: jcmd VM.events ignores max argument [v2]

2024-09-16 Thread Sonia Zaldana Calles
On Mon, 16 Sep 2024 19:51:20 GMT, Leonid Mesnik wrote: >> The inner 'int max;' declaration hide previous max. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - typo fixed. > - check added. Thanks! test/hotspot/jtreg/se

Re: RFR: 8340213: jcmd VM.events ignores max argument [v2]

2024-09-16 Thread Leonid Mesnik
> The inner 'int max;' declaration hide previous max. Leonid Mesnik has updated the pull request incrementally with two additional commits since the last revision: - typo fixed. - check added. - Changes: - all: https://git.openjdk.org/jdk/pull/21024/files - new: https://git.

Re: RFR: 8340213: jcmd VM.events ignores max argument

2024-09-16 Thread Sonia Zaldana Calles
On Mon, 16 Sep 2024 19:14:01 GMT, Leonid Mesnik wrote: > The inner 'int max;' declaration hide previous max. I am not a Reviewer but this looks good to me. test/hotspot/jtreg/serviceability/dcmd/vm/EventsTest.java line 81: > 79: long lines = output.asLines().stream().filter(x -> > x.

RFR: 8340213: jcmd VM.events ignores max argument

2024-09-16 Thread Leonid Mesnik
The inner 'int max;' declaration hide previous max. - Commit messages: - fixed typo - 8340213: jcmd VM.events ignores max argument Changes: https://git.openjdk.org/jdk/pull/21024/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21024&range=00 Issue: https://bugs.openjdk.